ca1849

mus65 · mus65 · commit 9283535ebc1f · 2025-08-14T20:42:19.000+02:00
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1849
diff --git a/src/Renci.SshNet/SftpClient.cs b/src/Renci.SshNet/SftpClient.cs
@@ -2363,13 +2363,15 @@ private async Task InternalUploadFile(
 
             while (true)
             {
+#pragma warning disable CA1849 // Call async methods when in an async method
                 var bytesRead = isAsync
 #if NET
                     ? await input.ReadAsync(buffer, cancellationToken).ConfigureAwait(false)
 #else
                     ? await input.ReadAsync(buffer, 0, buffer.Length, cancellationToken).ConfigureAwait(false)
 #endif
                     : input.Read(buffer, 0, buffer.Length);
+#pragma warning restore CA1849 // Call async methods when in an async method
 
                 if (bytesRead == 0)
                 {

Original file line number	Diff line number	Diff line change
`@@ -2363,13 +2363,15 @@ private async Task InternalUploadFile(`
`2363`	`2363`
`2364`	`2364`	`while (true)`
`2365`	`2365`	`{`
	`2366`	`+#pragma warning disable CA1849 // Call async methods when in an async method`
`2366`	`2367`	`var bytesRead = isAsync`
`2367`	`2368`	`#if NET`
`2368`	`2369`	`? await input.ReadAsync(buffer, cancellationToken).ConfigureAwait(false)`
`2369`	`2370`	`#else`
`2370`	`2371`	`? await input.ReadAsync(buffer, 0, buffer.Length, cancellationToken).ConfigureAwait(false)`
`2371`	`2372`	`#endif`
`2372`	`2373`	`: input.Read(buffer, 0, buffer.Length);`
	`2374`	`+#pragma warning restore CA1849 // Call async methods when in an async method`
`2373`	`2375`
`2374`	`2376`	`if (bytesRead == 0)`
`2375`	`2377`	`{`