!fixup Cleanup debug messages and use Error_Handler()

Author: kbumsik

cores/arduino/VirtIOSerial.cpp

@@ -44,9 +44,10 @@ void VirtIOSerial::begin(void)
   if (initialized) {
     return;
   }
-  OPENAMP_Init();
-  if (VIRT_UART_Init(&huart) != VIRT_UART_OK) {
-    // log_err("VIRT_UART_Init UART0 failed.\r\n");
+  if (OPENAMP_Init() != 0) {
+    Error_Handler();
+  }
+  if (VIRT_UART_Init(&virt_huart) != VIRT_UART_OK) {
     Error_Handler();
   }
   /*Need to register callback for message reception by channels*/
@@ -136,6 +137,7 @@ size_t VirtIOSerial::write(uint8_t ch)
 size_t VirtIOSerial::write(const uint8_t *buffer, size_t size)
 {
   if (VIRT_UART_Transmit(&huart, const_cast<uint8_t *>(buffer), size) == VIRT_UART_ERROR) {
+    // This error usually happens when rpmsg is not ready for 
     return 0;
   }
   return size;

cores/arduino/stm32/virtio/mbox_ipcc.c

@@ -80,13 +80,13 @@ int MAILBOX_Init(void)
 
   if (HAL_IPCC_ActivateNotification(&hipcc, IPCC_CHANNEL_1, IPCC_CHANNEL_DIR_RX,
                                     IPCC_channel1_callback) != HAL_OK) {
-    OPENAMP_log_err("%s: ch_1 RX fail\n", __func__);
+    Error_Handler();
     return -1;
   }
 
   if (HAL_IPCC_ActivateNotification(&hipcc, IPCC_CHANNEL_2, IPCC_CHANNEL_DIR_RX,
                                     IPCC_channel2_callback) != HAL_OK) {
-    OPENAMP_log_err("%s: ch_2 RX fail\n", __func__);
+    Error_Handler();
     return -1;
   }
 
@@ -106,27 +106,23 @@ int MAILBOX_Notify(void *priv, uint32_t id)
   /* Called after virtqueue processing: time to inform the remote */
   if (id == VRING0_ID) {
     channel = IPCC_CHANNEL_1;
-    OPENAMP_log_dbg("Send msg on ch_1\r\n");
   } else if (id == VRING1_ID) {
     /* Note: the OpenAMP framework never notifies this */
     channel = IPCC_CHANNEL_2;
-    OPENAMP_log_dbg("Send 'buff free' on ch_2\r\n");
     return -1;
   } else {
-    OPENAMP_log_err("invalid vring (%d)\r\n", (int)id);
     return -1;
   }
 
   /* Check that the channel is free (otherwise wait until it is) */
   if (HAL_IPCC_GetChannelStatus(&hipcc, channel, IPCC_CHANNEL_DIR_TX) == IPCC_CHANNEL_STATUS_OCCUPIED) {
-    OPENAMP_log_dbg("Waiting for channel to be freed\r\n");
+    // Wait for channel to be freed
     while (HAL_IPCC_GetChannelStatus(&hipcc, channel, IPCC_CHANNEL_DIR_TX) == IPCC_CHANNEL_STATUS_OCCUPIED)
       ;
   }
 
   /* Inform A7 (either new message, or buf free) */
   HAL_IPCC_NotifyCPU(&hipcc, channel, IPCC_CHANNEL_DIR_TX);
-
   return 0;
 }