chore: add parser error test

Author: avallete

package-lock.json

@@ -46,10 +46,10 @@
     "crypto-js": "^4.0.0",
     "fastify": "^4.24.3",
     "fastify-metrics": "^10.0.0",
-    "pg": "https://gitpkg.vercel.app/supabase/node-postgres/packages/pg?master",
+    "pg": "npm:@supabase/pg@0.0.3",
     "pg-connection-string": "^2.7.0",
     "pg-format": "^1.0.4",
-    "pg-protocol": "^1.7.0",
+    "pg-protocol": "npm:@supabase/pg-protocol@0.0.2",
     "pgsql-parser": "^13.16.0",
     "pino": "^9.5.0",
     "postgres-array": "^3.0.1",

package.json

@@ -1,4 +1,3 @@
-import { PoolConfig } from 'pg'
 import * as Parser from './Parser.js'
 import PostgresMetaColumnPrivileges from './PostgresMetaColumnPrivileges.js'
 import PostgresMetaColumns from './PostgresMetaColumns.js'
@@ -20,7 +19,7 @@ import PostgresMetaTypes from './PostgresMetaTypes.js'
 import PostgresMetaVersion from './PostgresMetaVersion.js'
 import PostgresMetaViews from './PostgresMetaViews.js'
 import { init } from './db.js'
-import { PostgresMetaResult } from './types.js'
+import { PostgresMetaResult, PoolConfig } from './types.js'
 
 export default class PostgresMeta {
   query: (sql: string) => Promise<PostgresMetaResult<any>>

src/lib/PostgresMeta.ts

@@ -22,7 +22,7 @@ pg.types.setTypeParser(1017, (x) => x) // _point
 
 // Ensure any query will have an appropriate error handler on the pool to prevent connections errors
 // to bubble up all the stack eventually killing the server
-const poolerQueryHandleError = (pool: pg.Pool, sql: string): Promise<pg.QueryResult<any>> => {
+const poolerQueryHandleError = (pgpool: pg.Pool, sql: string): Promise<pg.QueryResult<any>> => {
   return new Promise((resolve, reject) => {
     let rejected = false
     const connectionErrorHandler = (err: any) => {
@@ -38,8 +38,8 @@ const poolerQueryHandleError = (pool: pg.Pool, sql: string): Promise<pg.QueryRes
     }
     // This listened avoid getting uncaught exceptions for errors happening at connection level within the stream
     // such as parse or RESULT_SIZE_EXCEEDED errors instead, handle the error gracefully by bubbling in up to the caller
-    pool.once('error', connectionErrorHandler)
-    pool
+    pgpool.once('error', connectionErrorHandler)
+    pgpool
       .query(sql)
       .then((results: pg.QueryResult<any>) => {
         if (!rejected) {
@@ -196,7 +196,6 @@ ${' '.repeat(5 + lineNumber.toString().length + 2 + lineOffset)}^
               },
             }
           }
-
           return { data: null, error: { code: error.code, message: error.message } }
         } finally {
           // If the error isn't a "DatabaseError" assume it's a connection related we kill the connection

src/lib/db.ts

@@ -67,3 +67,74 @@ describe('test max-result-size limit', () => {
     expect(nextRes.json()).toHaveLength(50)
   })
 })
+
+describe('test js parser error max result', () => {
+  // Create a table with large data for testing
+  beforeAll(async () => {
+    // Create a table with a large text column
+    await pgMeta.query(`
+      CREATE TABLE very_large_data (
+        id SERIAL PRIMARY KEY,
+        data TEXT
+      );
+    `)
+
+    // Insert data that will exceed our limit in tests it's set around ~20MB
+    await pgMeta.query(`
+      INSERT INTO very_large_data (data)
+      VALUES (repeat('x', 710 * 1024 * 1024)) -- 700+MB string will raise a JS exception at parse time
+    `)
+  })
+
+  afterAll(async () => {
+    // Clean up the test table
+    await pgMeta.query('DROP TABLE very_large_data;')
+  })
+
+  test(
+    'should not kill the server on underlying parser error',
+    async () => {
+      // Set a small maxResultSize (50MB)
+      const res = await app.inject({
+        method: 'POST',
+        path: '/query',
+        payload: { query: 'SELECT * FROM very_large_data;' },
+      })
+
+      // Check that we get the proper error response from the underlying parser
+      expect(res.json()).toMatchInlineSnapshot(`
+      {
+        "error": "exception received while handling packet: Error: Cannot create a string longer than 0x1fffffe8 characters
+      ",
+        "formattedError": "exception received while handling packet: Error: Cannot create a string longer than 0x1fffffe8 characters
+      ",
+        "length": 744488975,
+        "message": "exception received while handling packet: Error: Cannot create a string longer than 0x1fffffe8 characters",
+        "name": "error",
+      }
+    `)
+
+      // Verify that subsequent queries still work and the server isn't killed
+      const nextRes = await app.inject({
+        method: 'POST',
+        path: '/query',
+        payload: { query: 'SELECT * FROM todos;' },
+      })
+      expect(nextRes.json()).toMatchInlineSnapshot(`
+      [
+        {
+          "details": "Star the repo",
+          "id": 1,
+          "user-id": 1,
+        },
+        {
+          "details": "Watch the releases",
+          "id": 2,
+          "user-id": 2,
+        },
+      ]
+    `)
+    },
+    { timeout: 20000 }
+  )
+})