fix: check property key instead of value in valid-prop-names-in-kit-pages rule (#1126)

Author: baseballyama

.changeset/gentle-guests-cross.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix: check property key instead of value in `valid-prop-names-in-kit-pages` rule

packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts

@@ -16,12 +16,12 @@ function checkProp(
 	for (const p of node.id.properties) {
 		if (
 			p.type === 'Property' &&
-			p.value.type === 'Identifier' &&
-			!expectedPropNames.includes(p.value.name)
+			p.key.type === 'Identifier' &&
+			!expectedPropNames.includes(p.key.name)
 		) {
 			context.report({
-				node: p.value,
-				loc: p.value.loc,
+				node: p.key,
+				loc: p.key.loc,
 				messageId: 'unexpected'
 			});
 		}

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/invalid/errors.yaml

@@ -14,11 +14,3 @@
   line: 4
   column: 20
   suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 21
-  suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 36
-  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/invalid/svelte-config-from-parser-options/errors.yaml

@@ -14,11 +14,3 @@
   line: 4
   column: 20
   suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 21
-  suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 36
-  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/invalid/svelte-config/errors.yaml

@@ -14,11 +14,3 @@
   line: 4
   column: 20
   suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 21
-  suggestions: null
-- message: disallow props other than data or errors in SvelteKit page components.
-  line: 5
-  column: 36
-  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5-typescript/+page.svelte

@@ -0,0 +1,5 @@
+<script lang="ts">
+	let { data: pageData }: { data: PageData } = $props();
+</script>
+
+{pageData}

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5-typescript/_config.json

@@ -0,0 +1,13 @@
+{
+	"languageOptions": {
+		"parserOptions": {
+			"svelteConfig": {
+				"kit": {
+					"files": {
+						"routes": "tests/fixtures/rules/valid-prop-names-in-kit-pages/invalid/svelte5"
+					}
+				}
+			}
+		}
+	}
+}

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-prop-names-in-kit-pages/valid/svelte5-typescript/requirements.json

@@ -0,0 +1,3 @@
+{
+	"svelte": ">=5.0.0-0"
+}