Fix unnecessary references in scope (#122)

* Fix unnecessary references in scope

* fix

Author: ota-meshi

src/context/script-let.ts

@@ -922,18 +922,24 @@ function removeIdentifierReference(
 
 /** Remove reference */
 function removeReference(reference: Reference, baseScope: Scope) {
-    if (
-        reference.resolved &&
-        reference.resolved.defs.some((d) => d.name === reference.identifier)
-    ) {
-        // remove var
-        const varIndex = baseScope.variables.indexOf(reference.resolved)
-        if (varIndex >= 0) {
-            baseScope.variables.splice(varIndex, 1)
-        }
-        const name = reference.identifier.name
-        if (reference.resolved === baseScope.set.get(name)) {
-            baseScope.set.delete(name)
+    if (reference.resolved) {
+        if (
+            reference.resolved.defs.some((d) => d.name === reference.identifier)
+        ) {
+            // remove var
+            const varIndex = baseScope.variables.indexOf(reference.resolved)
+            if (varIndex >= 0) {
+                baseScope.variables.splice(varIndex, 1)
+            }
+            const name = reference.identifier.name
+            if (reference.resolved === baseScope.set.get(name)) {
+                baseScope.set.delete(name)
+            }
+        } else {
+            const refIndex = reference.resolved.references.indexOf(reference)
+            if (refIndex >= 0) {
+                reference.resolved.references.splice(refIndex, 1)
+            }
         }
     }
 

tests/fixtures/parser/ast/ts-each01-input.svelte

@@ -0,0 +1,10 @@
+<script lang="ts">
+    const list: number[] = []
+    const items: {id:number, name:string}[] = []
+</script>
+{#each list as e}
+    {e}
+{/each}
+{#each items as item, index (item.id)}
+    {index}{item.name}
+{/each}