Skip to content

Commit 7b2d774

Browse files
authored
chore: update/simplify test (#16630)
* update/simplify test * oops * simplify effect-order-7
1 parent 95e5175 commit 7b2d774

File tree

9 files changed

+36
-66
lines changed

9 files changed

+36
-66
lines changed
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
<script>
22
import B from './B.svelte';
33
4-
let { boolean, closed } = $props();
4+
let { boolean, closed, close } = $props();
55
6+
// this runs after the effect in B, because child effects run first
67
$effect(() => {
7-
console.log(boolean);
8+
console.log({ boolean, closed });
89
});
910
</script>
1011

11-
<B {closed} />
12+
<B {closed} {close} />

packages/svelte/tests/runtime-runes/samples/effect-order-6/B.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<script>
2-
import { close } from './Child.svelte';
3-
4-
let { closed } = $props();
2+
let { closed, close } = $props();
53
64
$effect(() => {
75
if (closed) close();

packages/svelte/tests/runtime-runes/samples/effect-order-6/Child.svelte

Lines changed: 0 additions & 20 deletions
This file was deleted.

packages/svelte/tests/runtime-runes/samples/effect-order-6/_config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ export default test({
88
flushSync(() => open.click());
99
flushSync(() => close.click());
1010

11-
assert.deepEqual(logs, [true]);
11+
assert.deepEqual(logs, [{ boolean: true, closed: false }]);
1212
}
1313
});
Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
<script>
22
import A from './A.svelte';
3-
import Child, { open } from './Child.svelte';
3+
4+
let object = $state();
5+
6+
function open() {
7+
object = { boolean: true };
8+
}
9+
10+
function close() {
11+
object = undefined;
12+
}
413
514
let closed = $state(false);
615
</script>
@@ -15,9 +24,6 @@
1524

1625
<hr>
1726

18-
<Child>
19-
{#snippet children(boolean)}
20-
<A {closed} {boolean} />
21-
{/snippet}
22-
</Child>
23-
27+
{#if object}
28+
<A {closed} {close} boolean={object.boolean} />
29+
{/if}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<script>
22
import B from './B.svelte';
33
4-
let { boolean, closed } = $props();
4+
let { boolean, closed, close } = $props();
55
</script>
66

7-
<span>{boolean}</span>
7+
<span>{boolean} {closed}</span>
88

9-
<B {closed} />
9+
<B {closed} {close} />

packages/svelte/tests/runtime-runes/samples/effect-order-7/B.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<script>
2-
import { close } from './Child.svelte';
3-
4-
let { closed } = $props();
2+
let { closed, close } = $props();
53
64
$effect.pre(() => {
75
if (closed) close();

packages/svelte/tests/runtime-runes/samples/effect-order-7/Child.svelte

Lines changed: 0 additions & 20 deletions
This file was deleted.

packages/svelte/tests/runtime-runes/samples/effect-order-7/main.svelte

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
<script>
22
import A from './A.svelte';
3-
import Child, { open } from './Child.svelte';
3+
4+
let object = $state();
5+
6+
function open() {
7+
object = { boolean: true };
8+
}
9+
10+
function close() {
11+
object = undefined;
12+
}
413
514
let closed = $state(false);
615
</script>
@@ -15,8 +24,6 @@
1524

1625
<hr>
1726

18-
<Child>
19-
{#snippet children(nested)}
20-
<A {closed} boolean={nested.boolean} />
21-
{/snippet}
22-
</Child>
27+
{#if object}
28+
<A {close} {closed} boolean={object.boolean} />
29+
{/if}

0 commit comments

Comments
 (0)