Skip to content

Commit f2fea33

Browse files
committed
Don't set logging stream handler in library code
Closes #8263
1 parent b111ab8 commit f2fea33

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

modules/swagger-codegen/src/main/resources/python/configuration.mustache

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ class Configuration(object):
5656
self.logger["urllib3_logger"] = logging.getLogger("urllib3")
5757
# Log format
5858
self.logger_format = '%(asctime)s %(levelname)s %(message)s'
59-
# Log stream handler
60-
self.logger_stream_handler = None
6159
# Log file handler
6260
self.logger_file_handler = None
6361
# Debug file location
@@ -101,9 +99,6 @@ class Configuration(object):
10199
def logger_file(self):
102100
"""The logger file.
103101

104-
If the logger_file is None, then add stream handler and remove file
105-
handler. Otherwise, add file handler and remove stream handler.
106-
107102
:param value: The logger_file path.
108103
:type: str
109104
"""
@@ -113,29 +108,22 @@ class Configuration(object):
113108
def logger_file(self, value):
114109
"""The logger file.
115110

116-
If the logger_file is None, then add stream handler and remove file
117-
handler. Otherwise, add file handler and remove stream handler.
111+
If the logger_file is None, then remove file
112+
handler. Otherwise, add file handler.
118113

119114
:param value: The logger_file path.
120115
:type: str
121116
"""
122117
self.__logger_file = value
123118
if self.__logger_file:
124-
# If set logging file,
125-
# then add file handler and remove stream handler.
119+
# If set logging file, then add file handler.
126120
self.logger_file_handler = logging.FileHandler(self.__logger_file)
127121
self.logger_file_handler.setFormatter(self.logger_formatter)
128122
for _, logger in six.iteritems(self.logger):
129123
logger.addHandler(self.logger_file_handler)
130-
if self.logger_stream_handler:
131-
logger.removeHandler(self.logger_stream_handler)
132124
else:
133-
# If not set logging file,
134-
# then add stream handler and remove file handler.
135-
self.logger_stream_handler = logging.StreamHandler()
136-
self.logger_stream_handler.setFormatter(self.logger_formatter)
125+
# If not, remove file handler.
137126
for _, logger in six.iteritems(self.logger):
138-
logger.addHandler(self.logger_stream_handler)
139127
if self.logger_file_handler:
140128
logger.removeHandler(self.logger_file_handler)
141129

0 commit comments

Comments
 (0)