Clean up some NO_FILESYSTEM paths (#1210)

Author: parkera

Sources/FoundationEssentials/Data/Data+Reading.swift

@@ -31,6 +31,10 @@ import WinSDK
 @preconcurrency import WASILibc
 #endif
 
+#if FOUNDATION_FRAMEWORK && NO_FILESYSTEM
+@_spi(ENABLE_EXCLAVE_STORAGE) import C
+#endif
+
 func _fgetxattr(_ fd: Int32, _ name: UnsafePointer<CChar>!, _ value: UnsafeMutableRawPointer!, _ size: Int, _ position: UInt32, _ options: Int32) -> Int {
 #if canImport(Darwin)
     return fgetxattr(fd, name, value, size, position, options)
@@ -329,13 +333,13 @@ internal func readBytesFromFile(path inPath: PathOrURL, reportProgress: Bool, ma
     }
 
     let fileSize = min(Int(clamping: filestat.st_size), maxLength ?? Int.max)
-    let fileType = mode_t(filestat.st_mode) & S_IFMT
+    let fileType = mode_t(filestat.st_mode) & mode_t(S_IFMT)
 #if !NO_FILESYSTEM
     let shouldMap = shouldMapFileDescriptor(fd, path: inPath, options: options)
 #else
     let shouldMap = false
 #endif
-        
+
     if fileType != S_IFREG {
         // EACCES is still an odd choice, but at least we have a better error for directories.
         let code = (fileType == S_IFDIR) ? EISDIR : EACCES

Sources/FoundationEssentials/Data/Data+Writing.swift

@@ -12,8 +12,10 @@
 
 #if FOUNDATION_FRAMEWORK
 internal import _ForSwiftFoundation
+#if !NO_FILESYSTEM
 internal import DarwinPrivate // for VREG
 #endif
+#endif
 
 internal import _FoundationCShims
 

Sources/FoundationEssentials/Data/Data.swift

@@ -2135,10 +2135,6 @@ public struct Data : Equatable, Hashable, RandomAccessCollection, MutableCollect
     /// - parameter options: Options for the read operation. Default value is `[]`.
     /// - throws: An error in the Cocoa domain, if `url` cannot be read.
     public init(contentsOf url: __shared URL, options: ReadingOptions = []) throws {
-#if NO_FILESYSTEM
-        let d = try NSData(contentsOf: url, options: NSData.ReadingOptions(rawValue: options.rawValue))
-        self.init(referencing: d)
-#else
         if url.isFileURL {
             self = try readDataFromFile(path: .url(url), reportProgress: true, options: options)
         } else {
@@ -2150,16 +2146,10 @@ public struct Data : Equatable, Hashable, RandomAccessCollection, MutableCollect
             try self.init(_contentsOfRemote: url, options: options)
             #endif
         }
-#endif
     }
 
     internal init(contentsOfFile path: String, options: ReadingOptions = []) throws {
-#if NO_FILESYSTEM
-        let d = try NSData(contentsOfFile: path, options: NSData.ReadingOptions(rawValue: options.rawValue))
-        self.init(referencing: d)
-#else
         self = try readDataFromFile(path: .path(path), reportProgress: true, options: options)
-#endif
     }
 
     // -----------------------------------