Manually order nonisolated(nonsending) relative to @escaping in public interfaces

Author: owenv

Sources/LanguageServerProtocolTransport/JSONRPCConnection.swift

@@ -286,7 +286,7 @@ public final class JSONRPCConnection: Connection {
   /// - Important: `start` must be called before sending any data over the `JSONRPCConnection`.
   public func start(
     receiveHandler: MessageHandler,
-    closeHandler: @escaping @Sendable () async -> Void = {}
+    closeHandler: nonisolated(nonsending) @escaping @Sendable () async -> Void = {}
   ) {
     queue.sync {
       precondition(state == .created)

Sources/ToolsProtocolsSwiftExtensions/AsyncQueue.swift

@@ -93,7 +93,7 @@ public final class AsyncQueue<TaskMetadata: DependencyTracker>: Sendable {
   public func async<Success: Sendable>(
     priority: TaskPriority? = nil,
     metadata: TaskMetadata,
-    @_inheritActorContext operation: @escaping @Sendable () async -> Success
+    @_inheritActorContext operation: nonisolated(nonsending) @escaping @Sendable () async -> Success
   ) -> Task<Success, Never> {
     let throwingTask = asyncThrowing(priority: priority, metadata: metadata, operation: operation)
     return Task(priority: priority) {
@@ -114,7 +114,7 @@ public final class AsyncQueue<TaskMetadata: DependencyTracker>: Sendable {
   public func asyncThrowing<Success: Sendable>(
     priority: TaskPriority? = nil,
     metadata: TaskMetadata,
-    @_inheritActorContext operation: @escaping @Sendable () async throws -> Success
+    @_inheritActorContext operation: nonisolated(nonsending) @escaping @Sendable () async throws -> Success
   ) -> Task<Success, any Error> {
     let id = UUID()
 
@@ -178,7 +178,7 @@ extension AsyncQueue where TaskMetadata == Serial {
   @discardableResult
   public func async<Success: Sendable>(
     priority: TaskPriority? = nil,
-    @_inheritActorContext operation: @escaping @Sendable () async -> Success
+    @_inheritActorContext operation: nonisolated(nonsending) @escaping @Sendable () async -> Success
   ) -> Task<Success, Never> {
     return self.async(priority: priority, metadata: Serial(), operation: operation)
   }
@@ -187,7 +187,7 @@ extension AsyncQueue where TaskMetadata == Serial {
   /// for serial queues that don't specify any metadata.
   public func asyncThrowing<Success: Sendable>(
     priority: TaskPriority? = nil,
-    @_inheritActorContext operation: @escaping @Sendable () async throws -> Success
+    @_inheritActorContext operation: nonisolated(nonsending) @escaping @Sendable () async throws -> Success
   ) -> Task<Success, any Error> {
     return self.asyncThrowing(priority: priority, metadata: Serial(), operation: operation)
   }

Sources/ToolsProtocolsSwiftExtensions/AsyncUtils.swift

@@ -139,7 +139,7 @@ extension Collection where Self: Sendable, Element: Sendable {
   /// Transforms all elements in the collection concurrently and returns the transformed collection.
   @_spi(SourceKitLSP) public func concurrentMap<TransformedElement: Sendable>(
     maxConcurrentTasks: Int = ProcessInfo.processInfo.activeProcessorCount,
-    _ transform: @escaping @Sendable (Element) async -> TransformedElement
+    _ transform: nonisolated(nonsending) @escaping @Sendable (Element) async -> TransformedElement
   ) async -> [TransformedElement] {
     let indexedResults = await withTaskGroup(of: (index: Int, element: TransformedElement).self) { taskGroup in
       var indexedResults: [(index: Int, element: TransformedElement)] = []
@@ -170,7 +170,7 @@ extension Collection where Self: Sendable, Element: Sendable {
   }
 
   /// Invoke `body` for every element in the collection and wait for all calls of `body` to finish
-  @_spi(SourceKitLSP) public func concurrentForEach(_ body: @escaping @Sendable (Element) async -> Void) async {
+  @_spi(SourceKitLSP) public func concurrentForEach(_ body: nonisolated(nonsending) @escaping @Sendable (Element) async -> Void) async {
     await withTaskGroup(of: Void.self) { taskGroup in
       for element in self {
         taskGroup.addTask {

Sources/ToolsProtocolsSwiftExtensions/Task+WithPriorityChangedHandler.swift

@@ -19,7 +19,7 @@
 @_spi(SourceKitLSP) public func withTaskPriorityChangedHandler<T: Sendable>(
   initialPriority: TaskPriority = Task.currentPriority,
   pollingInterval: Duration = .seconds(0.1),
-  @_inheritActorContext operation: @escaping @Sendable () async throws -> T,
+  @_inheritActorContext operation: nonisolated(nonsending) @escaping @Sendable () async throws -> T,
   taskPriorityChanged: @escaping @Sendable () -> Void
 ) async throws -> T {
   let lastPriority = ThreadSafeBox(initialValue: initialPriority)