Skip to content

Commit e1d20db

Browse files
committed
[Runtime] Temporarily remove swift_release_preservemost_weak_placeholder.
This is breaking embedded due to its use of weak definitions for embedded versions of the runtime functions. The presence of a weak export in libswiftCore allows any strong symbol in libswiftCore to override a weak symbol elsewhere. Remove while we work out how to reconcile the two. rdar://163578646
1 parent 2ba29d3 commit e1d20db

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

stdlib/public/runtime/HeapObject.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,6 @@ asm(R"(
8686
.set _swift_retain_preservemost, _swift_retain
8787
.globl _swift_release_preservemost
8888
.set _swift_release_preservemost, _swift_release
89-
90-
// A weak definition can only be overridden by a strong definition if the
91-
// library with the strong definition contains at least one weak definition.
92-
// Create a placeholder weak definition here to allow that to work.
93-
.weak_definition _swift_release_preservemost_weak_placeholder
94-
.globl _swift_release_preservemost_weak_placeholder
95-
_swift_release_preservemost_weak_placeholder:
96-
.byte 0
9789
)");
9890
#endif
9991
#endif

0 commit comments

Comments
 (0)