Merge pull request #356 from swiftwasm/yt/fix-nullptr-write

kateinoigakukun · web-flow · commit 7ccca453ef77 · 2025-05-07T10:08:35.000+08:00
Fix null-ptr write with `pthread_create`
diff --git a/Sources/JavaScriptEventLoop/WebWorkerTaskExecutor.swift b/Sources/JavaScriptEventLoop/WebWorkerTaskExecutor.swift
@@ -412,8 +412,9 @@ public final class WebWorkerTaskExecutor: TaskExecutor {
                 let unmanagedContext = Unmanaged.passRetained(context)
                 contexts.append(unmanagedContext)
                 let ptr = unmanagedContext.toOpaque()
+                var thread = pthread_t(bitPattern: 0)
                 let ret = pthread_create(
-                    nil,
+                    &thread,
                     nil,
                     { ptr in
                         // Cast to a optional pointer to absorb nullability variations between platforms.
diff --git a/Tests/JavaScriptEventLoopTests/JavaScriptEventLoopTests.swift b/Tests/JavaScriptEventLoopTests/JavaScriptEventLoopTests.swift
@@ -157,7 +157,7 @@ final class JavaScriptEventLoopTests: XCTestCase {
             let result = try await promise2.value
             XCTAssertEqual(result, .string("3.0"))
         }
-        XCTAssertGreaterThanOrEqual(thenDiff, 200)
+        XCTAssertGreaterThanOrEqual(thenDiff, 150)
     }
 
     func testPromiseThenWithFailure() async throws {

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ final class JavaScriptEventLoopTests: XCTestCase {`
`157`	`157`	`let result = try await promise2.value`
`158`	`158`	`XCTAssertEqual(result, .string("3.0"))`
`159`	`159`	`}`
`160`		`- XCTAssertGreaterThanOrEqual(thenDiff, 200)`
	`160`	`+ XCTAssertGreaterThanOrEqual(thenDiff, 150)`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`func testPromiseThenWithFailure() async throws {`