fix(cdb): [125187689] tencentcloud_mysql_dr_instance optmize create PREPAID instance (#3426)

* add

* add

* add

* add

Author: SevenEarth

tencentcloud/services/cdb/resource_tc_mysql_dr_instance.go

@@ -144,7 +144,6 @@ func ResourceTencentCloudMysqlDrInstance() *schema.Resource {
 				ValidateFunc: tccommon.ValidateStringLengthInRange(1, 100),
 				Description:  "Private network ID. If `vpc_id` is set, this value is required.",
 			},
-
 			"security_groups": {
 				Type:     schema.TypeSet,
 				Optional: true,
@@ -435,8 +434,55 @@ func resourceTencentCloudMysqlDrInstanceUpdate(d *schema.ResourceData, meta inte
 	logId := tccommon.GetLogId(tccommon.ContextNil)
 	ctx := context.WithValue(context.TODO(), tccommon.LogIdKey, logId)
 
+	mysqlID := d.Id()
 	payType := getPayType(d).(int)
 
+	if d.HasChange("prepaid_period") {
+		if v, ok := d.GetOk("charge_type"); ok {
+			if v.(string) != MYSQL_CHARGE_TYPE_PREPAID {
+				return fmt.Errorf("`prepaid_period` only support prepaid instance.")
+			}
+		}
+	}
+
+	if d.HasChange("charge_type") {
+		oldChargeTypeInterface, newChargeTypeInterface := d.GetChange("charge_type")
+		oldChargeType := oldChargeTypeInterface.(string)
+		newChargeType := newChargeTypeInterface.(string)
+
+		if oldChargeType == MYSQL_CHARGE_TYPE_PREPAID && newChargeType == MYSQL_CHARGE_TYPE_POSTPAID {
+			return fmt.Errorf("`charge_type` only supports modification from `POSTPAID` to `PREPAID`.")
+		}
+
+		var period int = 1
+		if v, ok := d.GetOkExists("prepaid_period"); ok {
+			period = v.(int)
+		}
+
+		request := cdb.NewRenewDBInstanceRequest()
+		request.InstanceId = &mysqlID
+		request.ModifyPayType = helper.String(newChargeType)
+		request.TimeSpan = helper.IntInt64(period)
+		err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
+			result, err := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseMysqlClient().RenewDBInstance(request)
+			if err != nil {
+				return tccommon.RetryError(err, tccommon.InternalError)
+			} else {
+				log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
+			}
+
+			if result == nil || result.Response == nil {
+				return resource.NonRetryableError(fmt.Errorf("Renew DB instance failed, Response is nil."))
+			}
+
+			return nil
+		})
+
+		if err != nil {
+			return err
+		}
+	}
+
 	d.Partial(true)
 
 	if payType == MysqlPayByMonth {
@@ -563,13 +609,15 @@ func mysqlDrInstanceSet(ctx context.Context, requestInter interface{}, d *schema
 		}
 	}
 
-	if payType, ok := d.GetOk("pay_type"); ok && okByMonth {
+	payType, ok := d.GetOkExists("pay_type")
+	if (!ok || payType == -1) && okByMonth {
 		var period int
 		if !ok || payType == -1 {
 			period = d.Get("prepaid_period").(int)
 		} else {
 			period = d.Get("period").(int)
 		}
+
 		requestByMonth.Period = helper.IntInt64(period)
 	}
 

tencentcloud/services/cdb/resource_tc_mysql_dr_instance.md

@@ -1,38 +1,74 @@
-Provides a mysql instance resource to create read-only database instances.
+Provides a mysql instance resource to create CDB dr(disaster recovery) instance.
+
+~> **NOTE:** Field `charge_type` only supports modification from `POSTPAID` to `PREPAID`. And the default renewal period is 1 month. and you can also use the `prepaid_period` field to customize the renewal period.
 
 Example Usage
 
+Create POSTPAID dr instance
+
 ```hcl
-resource "tencentcloud_mysql_dr_instance" "mysql_dr" {
-  master_instance_id = "cdb-adjdu3t5"
+resource "tencentcloud_mysql_dr_instance" "example" {
+  master_instance_id = "cdb-3kwa3gfj"
   master_region      = "ap-guangzhou"
   auto_renew_flag    = 0
-  availability_zone  = "ap-shanghai-3"
+  availability_zone  = "ap-guangzhou-6"
   charge_type        = "POSTPAID"
   cpu                = 4
   device_type        = "UNIVERSAL"
-  first_slave_zone   = "ap-shanghai-4"
-  instance_name      = "mysql-dr-test-up"
+  first_slave_zone   = "ap-guangzhou-7"
+  instance_name      = "tf-example"
   mem_size           = 8000
+  project_id         = 0
+  security_groups = [
+    "sg-e6a8xxib",
+  ]
+  slave_deploy_mode = 1
+  slave_sync_mode   = 0
+  subnet_id         = "subnet-hhi88a58"
+  volume_size       = 100
+  vpc_id            = "vpc-i5yyodl9"
+  intranet_port     = 3360
+  tags = {
+    createBy = "Terraform"
+  }
+}
+```
+
+Create PREPAID dr instance
+
+```hcl
+resource "tencentcloud_mysql_dr_instance" "example" {
+  master_instance_id = "cdb-3kwa3gfj"
+  master_region      = "ap-guangzhou"
+  availability_zone  = "ap-guangzhou-6"
+  charge_type        = "PREPAID"
   prepaid_period     = 1
+  auto_renew_flag    = 1
+  cpu                = 4
+  device_type        = "UNIVERSAL"
+  first_slave_zone   = "ap-guangzhou-7"
+  instance_name      = "tf-example"
+  mem_size           = 8000
   project_id         = 0
   security_groups = [
-    "sg-q4d821qk",
+    "sg-e6a8xxib",
   ]
   slave_deploy_mode = 1
   slave_sync_mode   = 0
-  subnet_id         = "subnet-5vfntba5"
+  subnet_id         = "subnet-hhi88a58"
   volume_size       = 100
-  vpc_id            = "vpc-h6s1s3aa"
+  vpc_id            = "vpc-i5yyodl9"
   intranet_port     = 3360
   tags = {
-    test = "test-tf"
+    createBy = "Terraform"
   }
 }
 ```
+
 Import
 
-mysql dr database instances can be imported using the id, e.g.
+CDB dr(disaster recovery) instancecan be imported using the id, e.g.
+
+```
+terraform import tencentcloud_mysql_dr_instance.example cdb-bcet7sdb
 ```
-terraform import tencentcloud_mysql_dr_instance.mysql_dr cdb-bcet7sdb
-```

website/docs/r/mysql_dr_instance.html.markdown

@@ -4,40 +4,74 @@ layout: "tencentcloud"
 page_title: "TencentCloud: tencentcloud_mysql_dr_instance"
 sidebar_current: "docs-tencentcloud-resource-mysql_dr_instance"
 description: |-
-  Provides a mysql instance resource to create read-only database instances.
+  Provides a mysql instance resource to create CDB dr(disaster recovery) instance.
 ---
 
 # tencentcloud_mysql_dr_instance
 
-Provides a mysql instance resource to create read-only database instances.
+Provides a mysql instance resource to create CDB dr(disaster recovery) instance.
+
+~> **NOTE:** Field `charge_type` only supports modification from `POSTPAID` to `PREPAID`. And the default renewal period is 1 month. and you can also use the `prepaid_period` field to customize the renewal period.
 
 ## Example Usage
 
+### Create POSTPAID dr instance
+
 ```hcl
-resource "tencentcloud_mysql_dr_instance" "mysql_dr" {
-  master_instance_id = "cdb-adjdu3t5"
+resource "tencentcloud_mysql_dr_instance" "example" {
+  master_instance_id = "cdb-3kwa3gfj"
   master_region      = "ap-guangzhou"
   auto_renew_flag    = 0
-  availability_zone  = "ap-shanghai-3"
+  availability_zone  = "ap-guangzhou-6"
   charge_type        = "POSTPAID"
   cpu                = 4
   device_type        = "UNIVERSAL"
-  first_slave_zone   = "ap-shanghai-4"
-  instance_name      = "mysql-dr-test-up"
+  first_slave_zone   = "ap-guangzhou-7"
+  instance_name      = "tf-example"
   mem_size           = 8000
+  project_id         = 0
+  security_groups = [
+    "sg-e6a8xxib",
+  ]
+  slave_deploy_mode = 1
+  slave_sync_mode   = 0
+  subnet_id         = "subnet-hhi88a58"
+  volume_size       = 100
+  vpc_id            = "vpc-i5yyodl9"
+  intranet_port     = 3360
+  tags = {
+    createBy = "Terraform"
+  }
+}
+```
+
+### Create PREPAID dr instance
+
+```hcl
+resource "tencentcloud_mysql_dr_instance" "example" {
+  master_instance_id = "cdb-3kwa3gfj"
+  master_region      = "ap-guangzhou"
+  availability_zone  = "ap-guangzhou-6"
+  charge_type        = "PREPAID"
   prepaid_period     = 1
+  auto_renew_flag    = 1
+  cpu                = 4
+  device_type        = "UNIVERSAL"
+  first_slave_zone   = "ap-guangzhou-7"
+  instance_name      = "tf-example"
+  mem_size           = 8000
   project_id         = 0
   security_groups = [
-    "sg-q4d821qk",
+    "sg-e6a8xxib",
   ]
   slave_deploy_mode = 1
   slave_sync_mode   = 0
-  subnet_id         = "subnet-5vfntba5"
+  subnet_id         = "subnet-hhi88a58"
   volume_size       = 100
-  vpc_id            = "vpc-h6s1s3aa"
+  vpc_id            = "vpc-i5yyodl9"
   intranet_port     = 3360
   tags = {
-    test = "test-tf"
+    createBy = "Terraform"
   }
 }
 ```
@@ -81,8 +115,9 @@ In addition to all arguments above, the following attributes are exported:
 
 ## Import
 
-mysql dr database instances can be imported using the id, e.g.
+CDB dr(disaster recovery) instancecan be imported using the id, e.g.
+
 ```
-terraform import tencentcloud_mysql_dr_instance.mysql_dr cdb-bcet7sdb
+terraform import tencentcloud_mysql_dr_instance.example cdb-bcet7sdb
 ```