chore: fix linting problems (#208)

Author: timdeschryver

.eslintrc.json

@@ -49,7 +49,7 @@
         ],
         "@typescript-eslint/no-unused-expressions": "error",
         "@typescript-eslint/prefer-function-type": "error",
-        "@typescript-eslint/quotes": ["error", "single"],
+        "@typescript-eslint/quotes": "off",
         "@typescript-eslint/type-annotation-spacing": "error",
         "@typescript-eslint/no-explicit-any": "off",
         "arrow-body-style": "error",
@@ -107,9 +107,10 @@
     },
     {
       "files": ["*.spec.ts"],
-      "extends": ["plugin:testing-library/angular", "plugin:jest-dom/recommended"],
+      "extends": ["plugin:jest/recommended"],
       "rules": {
-        "testing-library/prefer-explicit-assert": "error"
+        "jest/no-done-callback": "off",
+        "jest/expect-expect": "off"
       }
     },
     {

angular.json

@@ -71,7 +71,7 @@
         "lint": {
           "builder": "@nrwl/linter:eslint",
           "options": {
-            "lintFilePatterns": ["apps/example-app/src/**/*.ts", "apps/example-app/src/**/*.html"]
+            "lintFilePatterns": ["apps/example-app/**/*.ts", "apps/example-app/**/*.html"]
           }
         },
         "test": {
@@ -106,11 +106,7 @@
         "lint": {
           "builder": "@nrwl/linter:eslint",
           "options": {
-            "lintFilePatterns": [
-              "projects/testing-library/src/**/*.ts",
-              "projects/testing-library/src/**/*.html",
-              "projects/testing-library/src/**/*.html"
-            ]
+            "lintFilePatterns": ["projects/testing-library/**/*.ts", "projects/testing-library/**/*.html"]
           }
         },
         "build": {
@@ -159,11 +155,7 @@
         "lint": {
           "builder": "@nrwl/linter:eslint",
           "options": {
-            "lintFilePatterns": [
-              "projects/jest-utils/src/**/*.ts",
-              "projects/jest-utils/src/**/*.html",
-              "projects/jest-utils/src/**/*.html"
-            ]
+            "lintFilePatterns": ["projects/jest-utils/**/*.ts", "projects/jest-utils/**/*.html"]
           }
         },
         "build": {

apps/example-app/.eslintrc.json

@@ -28,6 +28,10 @@
       },
       "plugins": ["@angular-eslint/eslint-plugin", "@typescript-eslint"]
     },
+    {
+      "files": ["*.spec.ts"],
+      "extends": ["plugin:testing-library/angular", "plugin:jest-dom/recommended"]
+    },
     {
       "files": ["*.html"],
       "extends": ["plugin:@nrwl/nx/angular-template"],

apps/example-app/src/app/issues/issue-106.spec.ts

@@ -6,7 +6,7 @@ import { render, screen, fireEvent, waitFor } from '@testing-library/angular';
   template: `<button (click)="toggleShow()" data-testid="toggle">toggle</button>
     <div *ngIf="show$ | async" data-testid="getme">Here I am</div>`,
 })
-export class TestSelectComponent {
+class TestSelectComponent {
   showSubj = new BehaviorSubject(false);
   show$ = this.showSubj.asObservable();
 

package.json

@@ -66,9 +66,10 @@
     "@typescript-eslint/eslint-plugin": "4.22.0",
     "@typescript-eslint/parser": "4.22.0",
     "cpy-cli": "^3.1.1",
-    "eslint": "7.24.0",
+    "eslint": "^7.25.0",
     "eslint-config-prettier": "8.2.0",
     "eslint-plugin-import": "latest",
+    "eslint-plugin-jest": "^24.3.5",
     "eslint-plugin-jest-dom": "3.8.0",
     "eslint-plugin-testing-library": "^4.0.1",
     "husky": "^4.2.5",

projects/jest-utils/.eslintrc.json

@@ -13,15 +13,15 @@
           "error",
           {
             "type": "attribute",
-            "prefix": "lib",
+            "prefix": "atl",
             "style": "camelCase"
           }
         ],
         "@angular-eslint/component-selector": [
           "error",
           {
             "type": "element",
-            "prefix": "lib",
+            "prefix": "atl",
             "style": "kebab-case"
           }
         ]

projects/jest-utils/tests/create-mock.spec.ts

@@ -1,8 +1,8 @@
 import { Component } from '@angular/core';
 import { TestBed } from '@angular/core/testing';
+import { fireEvent, render } from '@testing-library/angular';
 
 import { createMock, provideMock, Mock } from '../src/public_api';
-import { render, fireEvent } from '../../testing-library/src/public_api';
 
 class FixtureService {
   constructor(private foo: string, public bar: string) {}
@@ -13,10 +13,10 @@ class FixtureService {
 }
 
 @Component({
-  selector: 'fixture',
+  selector: 'atl-fixture',
   template: ` <button (click)="print()">Print</button> `,
 })
-export class FixtureComponent {
+class FixtureComponent {
   constructor(private service: FixtureService) {}
 
   print() {
@@ -39,6 +39,7 @@ it('provides a mock service', async () => {
   expect(service.print).toHaveBeenCalledTimes(1);
 });
 
+// eslint-disable-next-line jest/expect-expect
 it('is possible to write a mock implementation', async (done) => {
   const { getByText } = await render(FixtureComponent, {
     providers: [provideMock(FixtureService)],

projects/testing-library/.eslintrc.json

@@ -13,15 +13,15 @@
           "error",
           {
             "type": "attribute",
-            "prefix": "lib",
+            "prefix": ["atl"],
             "style": "camelCase"
           }
         ],
         "@angular-eslint/component-selector": [
           "error",
           {
             "type": "element",
-            "prefix": "lib",
+            "prefix": ["atl"],
             "style": "kebab-case"
           }
         ]

projects/testing-library/src/lib/testing-library.ts

@@ -358,6 +358,7 @@ if (typeof afterEach === 'function' && !process.env.ATL_SKIP_AUTO_CLEANUP) {
   });
 }
 
+// TODO: rename to `atl-wrapper-component`
 // eslint-disable-next-line @angular-eslint/component-selector
 @Component({ selector: 'wrapper-component', template: '' })
 class WrapperComponent {}

projects/testing-library/tests/auto-cleanup.spec.ts

@@ -2,8 +2,8 @@ import { Component, Input } from '@angular/core';
 import { render } from '../src/public_api';
 
 @Component({
-  selector: 'fixture',
-  template: ` Hello {{ name }}! `,
+  selector: 'atl-fixture',
+  template: `Hello {{ name }}!`,
 })
 class FixtureComponent {
   @Input() name: string;