fix getall skipping last token id

0xFirekeeper · 0xFirekeeper · commit 6ef31ae9a8e0 · 2023-05-02T20:53:44.000+03:00
diff --git a/Assets/Thirdweb/Core/Scripts/ERC1155.cs b/Assets/Thirdweb/Core/Scripts/ERC1155.cs
@@ -94,7 +94,7 @@ public async Task<List<NFT>> GetAll(QueryAllParams queryParams = null)
                 }
                 // TODO: Add Multicall
                 List<NFT> allNfts = new List<NFT>();
-                for (int i = start; i < end; i++)
+                for (int i = start; i <= end; i++)
                     allNfts.Add(await Get(i.ToString()));
                 return allNfts;
             }
diff --git a/Assets/Thirdweb/Core/Scripts/ERC721.cs b/Assets/Thirdweb/Core/Scripts/ERC721.cs
@@ -102,7 +102,7 @@ public async Task<List<NFT>> GetAll(QueryAllParams queryParams = null)
                 catch (System.Exception)
                 {
                     List<NFT> allNfts = new List<NFT>();
-                    for (int i = start; i < end; i++)
+                    for (int i = start; i <= end; i++)
                         allNfts.Add(await Get(i.ToString()));
                     return allNfts;
                 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public async Task<List<NFT>> GetAll(QueryAllParams queryParams = null)`
`94`	`94`	`}`
`95`	`95`	`// TODO: Add Multicall`
`96`	`96`	`List<NFT> allNfts = new List<NFT>();`
`97`		`- for (int i = start; i < end; i++)`
	`97`	`+ for (int i = start; i <= end; i++)`
`98`	`98`	`allNfts.Add(await Get(i.ToString()));`
`99`	`99`	`return allNfts;`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public async Task<List<NFT>> GetAll(QueryAllParams queryParams = null)`
`102`	`102`	`catch (System.Exception)`
`103`	`103`	`{`
`104`	`104`	`List<NFT> allNfts = new List<NFT>();`
`105`		`- for (int i = start; i < end; i++)`
	`105`	`+ for (int i = start; i <= end; i++)`
`106`	`106`	`allNfts.Add(await Get(i.ToString()));`
`107`	`107`	`return allNfts;`
`108`	`108`	`}`