hexify external wallet personal_sign

new metamask mobile versions require this for display now

Author: 0xFirekeeper

Assets/Thirdweb/Runtime/Unity/Wallets/Core/MetaMaskWallet.cs

@@ -91,8 +91,8 @@ public Task<string> PersonalSign(byte[] rawMessage)
                 throw new ArgumentNullException(nameof(rawMessage), "Message to sign cannot be null.");
             }
 
-            var message = Encoding.UTF8.GetString(rawMessage);
-            return PersonalSign(message);
+            var hex = Utils.BytesToHex(rawMessage);
+            return PersonalSign(hex);
         }
 
         public async Task<string> PersonalSign(string message)
@@ -102,7 +102,7 @@ public async Task<string> PersonalSign(string message)
                 throw new ArgumentNullException(nameof(message), "Message to sign cannot be null or empty.");
             }
 
-            var rpcRequest = new RpcRequest { Method = "personal_sign", Params = new object[] { message, WebGLMetaMask.Instance.GetAddress() } };
+            var rpcRequest = new RpcRequest { Method = "personal_sign", Params = new object[] { message.StartsWith("0x") ? message : message.StringToHex(), WebGLMetaMask.Instance.GetAddress() } };
             return await WebGLMetaMask.Instance.RequestAsync<string>(rpcRequest);
         }
 

Assets/Thirdweb/Runtime/Unity/Wallets/Core/WalletConnectWallet.cs

@@ -149,8 +149,8 @@ public Task<string> PersonalSign(byte[] rawMessage)
                 throw new ArgumentNullException(nameof(rawMessage), "Message to sign cannot be null.");
             }
 
-            var message = Encoding.UTF8.GetString(rawMessage);
-            return PersonalSign(message);
+            var hex = Utils.BytesToHex(rawMessage);
+            return PersonalSign(hex);
         }
 
         public async Task<string> PersonalSign(string message)
@@ -160,7 +160,7 @@ public async Task<string> PersonalSign(string message)
                 throw new ArgumentNullException(nameof(message), "Message to sign cannot be null.");
             }
 
-            var task = _walletConnectService.PersonalSignAsync(message);
+            var task = _walletConnectService.PersonalSignAsync(message.StartsWith("0x") ? message : message.StringToHex());
             SessionRequestDeeplink();
             return await task as string;
         }