!squash test_waiter: Remove time.sleep - the point of the module is we

don't worry about that anymore

Author: tony

tests/_internal/test_waiter.py

@@ -186,9 +186,6 @@ def test_wait_for_pane_content_timeout(wait_pane: Pane) -> None:
     # Clear the pane to ensure test content isn't there
     wait_pane.send_keys("clear", enter=True)
 
-    # Make sure the clear command completed
-    time.sleep(0.5)
-
     # Wait for content that will never appear, but don't raise exception
     result = wait_for_pane_content(
         wait_pane,
@@ -255,9 +252,6 @@ def test_wait_until_pane_ready_error_handling(wait_pane: Pane) -> None:
     wait_pane.send_keys("clear", enter=True)
     wait_pane.send_keys("echo 'test'", enter=True)
 
-    # Wait a bit for the command to complete
-    time.sleep(0.5)
-
     # Should auto-detect shell prompt
     result = wait_until_pane_ready(
         wait_pane,
@@ -276,9 +270,6 @@ def test_wait_until_pane_ready_with_invalid_prompt(wait_pane: Pane) -> None:
     wait_pane.send_keys("clear", enter=True)
     wait_pane.send_keys("echo 'testing invalid prompt'", enter=True)
 
-    # Wait a bit for the command to complete
-    time.sleep(0.5)
-
     # With an invalid prompt and raises=False, should not raise but return failure
     result = wait_until_pane_ready(
         wait_pane,
@@ -341,7 +332,6 @@ def test_wait_for_window_panes(server: Server, session: Session) -> None:
 
     # Split and create a second pane with delay
     def split_pane() -> None:
-        time.sleep(0.2)
         window.split()
 
     import threading
@@ -400,7 +390,6 @@ def test_wait_for_window_panes_count_range(session: Session) -> None:
 
     # Split window to create a second pane
     window.split()
-    time.sleep(0.5)
 
     # Should now have 2 panes
     result = wait_for_window_panes(
@@ -430,7 +419,6 @@ def test_wait_for_any_content(wait_pane: Pane) -> None:
 
     # Add content with delay
     def add_content() -> None:
-        time.sleep(0.2)
         wait_pane.send_keys(
             "echo 'Success: Operation completed'",
             enter=True,
@@ -466,16 +454,13 @@ def add_content() -> None:
 def test_wait_for_any_content_mixed_match_types(wait_pane: Pane) -> None:
     """Test wait_for_any_content with different match types for each pattern."""
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)
 
     # Create different patterns with different match types
     wait_pane.send_keys("echo 'test line one'", enter=True)
     wait_pane.send_keys("echo 'number 123'", enter=True)
     wait_pane.send_keys("echo 'exact match text'", enter=True)
     wait_pane.send_keys("echo 'predicate target'", enter=True)
 
-    time.sleep(0.5)
-
     # Define a predicate function for testing
     def has_predicate_text(lines: list[str]) -> bool:
         return any("predicate target" in line for line in lines)
@@ -551,7 +536,6 @@ def test_wait_for_all_content(wait_pane: Pane) -> None:
     wait_pane.send_keys("clear", enter=True)  # Ensure clean state
 
     def add_content() -> None:
-        time.sleep(0.2)
         wait_pane.send_keys(
             "echo 'Database connected'; echo 'Server started'",
             enter=True,
@@ -591,11 +575,9 @@ def add_content() -> None:
 def test_wait_for_all_content_no_raise(wait_pane: Pane) -> None:
     """Test wait_for_all_content with raises=False."""
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)
 
     # Add content that will be found
     wait_pane.send_keys("echo 'Found text'", enter=True)
-    time.sleep(0.5)
 
     # Look for one pattern that exists and one that doesn't
     patterns: list[str | re.Pattern[str] | Callable[[list[str]], bool]] = [
@@ -620,14 +602,11 @@ def test_wait_for_all_content_no_raise(wait_pane: Pane) -> None:
 def test_wait_for_all_content_mixed_match_types(wait_pane: Pane) -> None:
     """Test wait_for_all_content with different match types for each pattern."""
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)
 
     # Add content that matches different patterns
     wait_pane.send_keys("echo 'contains test'", enter=True)
     wait_pane.send_keys("echo 'number 456'", enter=True)
 
-    time.sleep(0.5)
-
     # Define different match types
     match_types = [
         ContentMatchType.CONTAINS,  # For string match
@@ -686,15 +665,11 @@ def test_wait_for_all_content_type_error(wait_pane: Pane) -> None:
 def test_wait_for_pane_content_exact_match(wait_pane: Pane) -> None:
     """Test waiting for content with exact match."""
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)  # Wait for clear to take effect
 
     # Add a line with a predictable content
     test_content = "EXACT_MATCH_TEST_STRING"
     wait_pane.send_keys(f"echo '{test_content}'", enter=True)
 
-    # Wait for content to ensure it's present
-    time.sleep(0.5)
-
     # Instead of trying exact match on a line (which is prone to shell prompt
     # variations) Let's test if the content contains our string
     result = wait_for_pane_content(
@@ -817,7 +792,6 @@ def test_pane_content_waiter_wait_for_exact_text(wait_pane: Pane) -> None:
     """Test PaneContentWaiter wait_for_exact_text method."""
     wait_pane.send_keys("clear", enter=True)
     wait_pane.send_keys("echo 'Exact Test'", enter=True)
-    time.sleep(0.5)  # Give time for the command to complete
 
     # Use CONTAINS instead of EXACT for more reliable test
     result = (
@@ -890,9 +864,7 @@ def test_expect_function_with_method_chaining(wait_pane: Pane) -> None:
     """Test expect function with method chaining."""
     # Prepare content
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.1)
     wait_pane.send_keys("echo 'hello world'", enter=True)
-    time.sleep(0.1)
 
     # Test expect with method chaining
     result = (
@@ -909,7 +881,6 @@ def test_expect_function_with_method_chaining(wait_pane: Pane) -> None:
 
     # Test without_raising option
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.1)
 
     result = (
         expect(wait_pane)
@@ -926,13 +897,11 @@ def test_pane_content_waiter_with_line_range(wait_pane: Pane) -> None:
     """Test PaneContentWaiter with_line_range method."""
     # Clear the pane first
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)  # Ensure the clear command completes
 
     # Add some content
     wait_pane.send_keys("echo 'line1'", enter=True)
     wait_pane.send_keys("echo 'line2'", enter=True)
     wait_pane.send_keys("echo 'target-text'", enter=True)
-    time.sleep(0.2)  # Wait for the commands to complete
 
     # Test with specific line range - use a short timeout as we expect this
     # to be found immediately
@@ -967,11 +936,9 @@ def test_pane_content_waiter_wait_until_ready(wait_pane: Pane) -> None:
     """Test PaneContentWaiter wait_until_ready method."""
     # Clear the pane content first
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.1)
 
     # Add a shell prompt
     wait_pane.send_keys("echo '$'", enter=True)
-    time.sleep(0.1)
 
     # Test wait_until_ready with specific prompt pattern
     waiter = PaneContentWaiter(wait_pane).with_timeout(1.0)
@@ -985,11 +952,9 @@ def test_pane_content_waiter_with_invalid_line_range(wait_pane: Pane) -> None:
     """Test PaneContentWaiter with invalid line ranges."""
     # Clear the pane first
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)
 
     # Add some content to match
     wait_pane.send_keys("echo 'test content'", enter=True)
-    time.sleep(0.2)
 
     # Test with end < start - should use default range
     waiter = (
@@ -1026,13 +991,11 @@ def test_wait_for_pane_content_regex_line_match(wait_pane: Pane) -> None:
     """Test wait_for_pane_content with regex match and line detection."""
     # Clear the pane
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)
 
     # Add multiple lines with patterns
     wait_pane.send_keys("echo 'line 1 normal'", enter=True)
     wait_pane.send_keys("echo 'line 2 with pattern abc123'", enter=True)
     wait_pane.send_keys("echo 'line 3 normal'", enter=True)
-    time.sleep(0.2)
 
     # Create a regex pattern to find the line with the number pattern
     pattern = re.compile(r"pattern [a-z0-9]+")
@@ -1061,12 +1024,10 @@ def test_wait_for_all_content_with_line_range(wait_pane: Pane) -> None:
     """Test wait_for_all_content with line range specification."""
     # Clear the pane first
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)  # Ensure the clear command completes
 
     # Add some content
     wait_pane.send_keys("echo 'Line 1'", enter=True)
     wait_pane.send_keys("echo 'Line 2'", enter=True)
-    time.sleep(0.2)  # Wait for commands to complete
 
     patterns: list[str | re.Pattern[str] | Callable[[list[str]], bool]] = [
         "Line 1",
@@ -1092,7 +1053,6 @@ def test_wait_for_all_content_timeout(wait_pane: Pane) -> None:
     """Test wait_for_all_content timeout behavior without raising exception."""
     # Clear the pane first
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)  # Ensure the clear command completes
 
     # Pattern that won't be found in the pane content
     patterns: list[str | re.Pattern[str] | Callable[[list[str]], bool]] = [
@@ -1214,12 +1174,10 @@ def test_wait_for_any_content_with_predicates(wait_pane: Pane) -> None:
     """Test wait_for_any_content with predicate functions."""
     # Clear and prepare pane
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)
 
     # Add some content
     wait_pane.send_keys("echo 'Line 1'", enter=True)
     wait_pane.send_keys("echo 'Line 2'", enter=True)
-    time.sleep(0.2)
 
     # Define two predicate functions, one that will match and one that won't
     def has_two_lines(content: list[str]) -> bool:
@@ -1248,12 +1206,10 @@ def test_wait_for_pane_content_with_line_range(wait_pane: Pane) -> None:
     """Test wait_for_pane_content with line range."""
     # Clear and prepare pane
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.2)
 
     # Add numbered lines
     for i in range(5):
         wait_pane.send_keys(f"echo 'Line {i}'", enter=True)
-    time.sleep(0.2)
 
     # Test with line range
     result = wait_for_pane_content(
@@ -1458,7 +1414,6 @@ def test_wait_for_any_content_exact_match(wait_pane: Pane) -> None:
     """
     # Clear the pane and add specific content
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)  # Short delay to ensure clear happens
 
     # Capture the current content to match it exactly later
     content = wait_pane.capture_pane()
@@ -1496,7 +1451,6 @@ def test_wait_for_any_content_string_regex(wait_pane: Pane) -> None:
     """
     # Clear the pane
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)  # Short delay to ensure clear happens
 
     # Add content with patterns to match
     wait_pane.send_keys("Number ABC-123", enter=True)
@@ -1519,12 +1473,9 @@ def test_wait_for_any_content_string_regex(wait_pane: Pane) -> None:
 
     # Test focusing on just the string pattern for the next test
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)
 
     # Add only a string pattern match, ensuring it's the only match
     wait_pane.send_keys("Pattern XYZ-789", enter=True)
-    # Wait a bit to make sure cmd is processed
-    time.sleep(0.5)
 
     # First check if the content has our pattern
     content = wait_pane.capture_pane()
@@ -1554,7 +1505,6 @@ def test_wait_for_all_content_predicate_match_numbering(wait_pane: Pane) -> None
     """
     # Add some content to the pane
     wait_pane.send_keys("clear", enter=True)
-    time.sleep(0.5)  # Short delay to ensure clear happens
 
     wait_pane.send_keys("Predicate Line 1", enter=True)
     wait_pane.send_keys("Predicate Line 2", enter=True)
@@ -1891,11 +1841,9 @@ def test_wait_for_pane_content_exact_match_detailed(wait_pane: Pane) -> None:
     """
     # Clear the pane first to have more predictable content
     wait_pane.clear()
-    time.sleep(0.3)  # Give time for clear to take effect
 
     # Send a unique string that we can test with an exact match
     wait_pane.send_keys("UNIQUE_TEST_STRING_123", literal=True)
-    time.sleep(0.3)  # Give more time for content to appear
 
     # Get the current content to work with
     content = wait_pane.capture_pane()
@@ -1952,9 +1900,6 @@ def test_wait_for_pane_content_with_invalid_prompt(wait_pane: Pane) -> None:
     wait_pane.send_keys("clear", enter=True)
     wait_pane.send_keys("echo 'testing invalid prompt'", enter=True)
 
-    # Wait a bit for the command to complete
-    time.sleep(0.5)
-
     # With a non-matching pattern and raises=False, should not raise but return failure
     result = wait_for_pane_content(
         wait_pane,