Fix @typescript-eslint disable rules. (#1093)

* Fix @typescript-eslint disable rules.

* Refactor meta test.

* Add a missing rule to the typescript-eslint extension table.

* Delete unneccessary test.

Author: Res42

src/converters/lintConfigs/rules/ruleConverters/align.ts

@@ -29,6 +29,10 @@ export const convertAlign: RuleConverter = (tslintRule) => {
 
     return {
         rules: [
+            {
+                ruleName: "indent",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/indent",
                 ...{ ruleArguments },

src/converters/lintConfigs/rules/ruleConverters/indent.ts

@@ -11,6 +11,10 @@ export const convertIndent: RuleConverter = (tslintRule) => {
 
     return {
         rules: [
+            {
+                ruleName: "indent",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/indent",
                 ...(indentSize !== 4 && { ruleArguments: [indentSize] }),

src/converters/lintConfigs/rules/ruleConverters/no-async-without-await.ts

@@ -3,6 +3,10 @@ import { RuleConverter } from "../ruleConverter";
 export const convertNoAsyncWithoutAwait: RuleConverter = () => {
     return {
         rules: [
+            {
+                ruleName: "require-await",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/require-await",
             },

src/converters/lintConfigs/rules/ruleConverters/no-empty.ts

@@ -1,11 +1,8 @@
-import { isDefined } from "../../../../utils";
-import { RuleConverter, RuleConverterOptions } from "../ruleConverter";
+import { ConvertedRuleChanges, RuleConverter, RuleConverterOptions } from "../ruleConverter";
 
 export const convertNoEmpty: RuleConverter = (tslintRule) => {
     return {
-        rules: [convertNoEmptyRule(tslintRule), convertNoEmptyFunctionRule(tslintRule)].filter(
-            isDefined,
-        ),
+        rules: [convertNoEmptyRule(tslintRule), ...convertNoEmptyFunctionRule(tslintRule)],
     };
 };
 
@@ -22,10 +19,16 @@ const convertNoEmptyRule = (tslintRule: RuleConverterOptions) => {
     };
 };
 
-const convertNoEmptyFunctionRule = (tslintRule: RuleConverterOptions) => {
+const convertNoEmptyFunctionRule = (tslintRule: RuleConverterOptions): ConvertedRuleChanges[] => {
     return tslintRule.ruleArguments.includes("allow-empty-functions")
-        ? undefined
-        : {
-              ruleName: "@typescript-eslint/no-empty-function",
-          };
+        ? []
+        : [
+              {
+                  ruleName: "no-empty-function",
+                  ruleSeverity: "off",
+              },
+              {
+                  ruleName: "@typescript-eslint/no-empty-function",
+              },
+          ];
 };

src/converters/lintConfigs/rules/ruleConverters/no-shadowed-variable.ts

@@ -37,6 +37,10 @@ export const convertNoShadowedVariable: RuleConverter = (tslintRule) => {
 
     return {
         rules: [
+            {
+                ruleName: "no-shadow",
+                ruleSeverity: "off",
+            },
             {
                 ...(notices.length !== 0 && { notices }),
                 ...(ruleArguments.length !== 0 && { ruleArguments }),

src/converters/lintConfigs/rules/ruleConverters/no-string-literal.ts

@@ -3,6 +3,10 @@ import { RuleConverter } from "../ruleConverter";
 export const convertNoStringLiteral: RuleConverter = () => {
     return {
         rules: [
+            {
+                ruleName: "dot-notation",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/dot-notation",
             },

src/converters/lintConfigs/rules/ruleConverters/no-unused-expression.ts

@@ -3,6 +3,10 @@ import { RuleConverter } from "../ruleConverter";
 export const convertNoUnusedExpression: RuleConverter = (tslintRule) => {
     return {
         rules: [
+            {
+                ruleName: "no-unused-expressions",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/no-unused-expressions",
                 ...collectNoticesAndArguments(tslintRule.ruleArguments),

src/converters/lintConfigs/rules/ruleConverters/no-unused-variable.ts

@@ -7,6 +7,10 @@ export const NO_UNUSED_VARIABLE_NOTICE =
 export const convertNoUnusedVariable: RuleConverter = () => {
     return {
         rules: [
+            {
+                ruleName: "no-unused-vars",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/no-unused-vars",
                 notices: [NO_UNUSED_VARIABLE_NOTICE],

src/converters/lintConfigs/rules/ruleConverters/no-use-before-declare.ts

@@ -3,6 +3,10 @@ import { RuleConverter } from "../ruleConverter";
 export const convertNoUseBeforeDeclare: RuleConverter = () => {
     return {
         rules: [
+            {
+                ruleName: "no-use-before-define",
+                ruleSeverity: "off",
+            },
             {
                 ruleName: "@typescript-eslint/no-use-before-define",
             },

src/converters/lintConfigs/rules/ruleConverters/quotemark.ts

@@ -24,6 +24,10 @@ export const convertQuotemark: RuleConverter = (tslintRule) => {
 
     return {
         rules: [
+            {
+                ruleName: "quotes",
+                ruleSeverity: "off",
+            },
             {
                 ...(notices.length !== 0 && { notices }),
                 ...(ruleArguments.length !== 0 && { ruleArguments }),