Added prefer-array-literal converter (#1009)

* Added prefer-array-literal constructor

No rule options. Nice and easy.

* Post merge touchups

* Added no-array-constructor off

Author: Josh Goldberg

src/api/convertFileCommentsStandalone.ts

@@ -33,8 +33,8 @@ export type ConvertFileCommentsStandaloneDependencies = {
 export const convertFileCommentsStandalone = ({
     fileContent,
     filePath,
-    ruleCommentsCache = new Map(),
-    ruleEquivalents = new Map(),
+    ruleCommentsCache = new Map<string, string[]>(),
+    ruleEquivalents = new Map<string, string[]>(),
 }: ConvertFileCommentsStandaloneDependencies) => {
     const comments = parseFileComments(filePath, fileContent);
 

src/converters/lintConfigs/rules/ruleConverters.ts

@@ -112,6 +112,7 @@ import { convertOneLine } from "./ruleConverters/one-line";
 import { convertOneVariablePerDeclaration } from "./ruleConverters/one-variable-per-declaration";
 import { convertOnlyArrowFunctions } from "./ruleConverters/only-arrow-functions";
 import { convertOrderedImports } from "./ruleConverters/ordered-imports";
+import { convertPreferArrayLiteral } from "./ruleConverters/prefer-array-literal";
 import { convertPreferConditionalExpression } from "./ruleConverters/prefer-conditional-expression";
 import { convertPreferConst } from "./ruleConverters/prefer-const";
 import { convertPreferForOf } from "./ruleConverters/prefer-for-of";
@@ -376,6 +377,7 @@ export const ruleConverters = new Map([
     ["only-arrow-functions", convertOnlyArrowFunctions],
     ["ordered-imports", convertOrderedImports],
     ["pipe-prefix", convertPipePrefix],
+    ["prefer-array-literal", convertPreferArrayLiteral],
     ["prefer-conditional-expression", convertPreferConditionalExpression],
     ["prefer-const", convertPreferConst],
     ["prefer-for-of", convertPreferForOf],

src/converters/lintConfigs/rules/ruleConverters/prefer-array-literal.ts

@@ -0,0 +1,15 @@
+import { RuleConverter } from "../ruleConverter";
+
+export const convertPreferArrayLiteral: RuleConverter = () => {
+    return {
+        rules: [
+            {
+                ruleName: "no-array-constructor",
+                ruleSeverity: "off"
+            },
+            {
+                ruleName: "@typescript-eslint/no-array-constructor",
+            },
+        ],
+    };
+};

src/converters/lintConfigs/rules/ruleConverters/tests/prefer-array-literal.test.ts

@@ -0,0 +1,21 @@
+import { convertPreferArrayLiteral } from "../prefer-array-literal";
+
+describe(convertPreferArrayLiteral, () => {
+    test("conversion without arguments", () => {
+        const result = convertPreferArrayLiteral({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "no-array-constructor",
+                    ruleSeverity: "off"
+                },
+                {
+                    ruleName: "@typescript-eslint/no-array-constructor",
+                },
+            ],
+        });
+    });
+});