chore: add type to all rules (#673)

armano2 · michalsnik · commit b18d351bf931 · 2018-11-23T11:38:39.000+01:00
* chore: add type to all rules

Make sure that --fix-type cli parameter works with our plugin

* Update require-v-for-key.js

* Add suggestions from mysticatea
diff --git a/lib/rules/attribute-hyphenation.js b/lib/rules/attribute-hyphenation.js
@@ -13,6 +13,7 @@ const casing = require('../utils/casing')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce attribute naming style on custom components in template',
       category: 'strongly-recommended',
diff --git a/lib/rules/attributes-order.js b/lib/rules/attributes-order.js
@@ -103,6 +103,7 @@ function create (context) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce order of attributes',
       category: 'recommended',
diff --git a/lib/rules/comment-directive.js b/lib/rules/comment-directive.js
@@ -106,6 +106,7 @@ function processLine (context, comment) {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'support comment-directives in `<template>`',
       category: 'base',
diff --git a/lib/rules/component-name-in-template-casing.js b/lib/rules/component-name-in-template-casing.js
@@ -20,6 +20,7 @@ const defaultCase = 'PascalCase'
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce specific casing for the component naming style in template',
       category: 'strongly-recommended',
diff --git a/lib/rules/html-closing-bracket-newline.js b/lib/rules/html-closing-bracket-newline.js
@@ -29,6 +29,7 @@ function getPhrase (lineBreaks) {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: "require or disallow a line break before tag's closing brackets",
       category: 'strongly-recommended',
diff --git a/lib/rules/html-closing-bracket-spacing.js b/lib/rules/html-closing-bracket-spacing.js
@@ -50,6 +50,7 @@ function parseOptions (options, tokens) {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'require or disallow a space before tag\'s closing brackets',
       category: 'strongly-recommended',
diff --git a/lib/rules/html-end-tags.js b/lib/rules/html-end-tags.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce end tag style',
       category: 'strongly-recommended',
diff --git a/lib/rules/html-indent.js b/lib/rules/html-indent.js
@@ -26,6 +26,7 @@ module.exports = {
     return utils.defineTemplateBodyVisitor(context, visitor)
   },
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce consistent indentation in `<template>`',
       category: 'strongly-recommended',
diff --git a/lib/rules/html-quotes.js b/lib/rules/html-quotes.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce quotes style of HTML attributes',
       category: 'recommended',
diff --git a/lib/rules/html-self-closing.js b/lib/rules/html-self-closing.js
@@ -85,6 +85,7 @@ function isEmpty (node, sourceCode) {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce self-closing style',
       category: 'strongly-recommended',
diff --git a/lib/rules/jsx-uses-vars.js b/lib/rules/jsx-uses-vars.js
@@ -36,6 +36,7 @@ SOFTWARE.
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'prevent variables used in JSX to be marked as unused', // eslint-disable-line consistent-docs-description
       category: 'base',
diff --git a/lib/rules/max-attributes-per-line.js b/lib/rules/max-attributes-per-line.js
@@ -11,6 +11,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce the maximum number of attributes per line',
       category: 'strongly-recommended',
diff --git a/lib/rules/multiline-html-element-content-newline.js b/lib/rules/multiline-html-element-content-newline.js
@@ -50,6 +50,7 @@ function isEmpty (node, sourceCode) {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'require a line break before and after the contents of a multiline element',
       category: 'strongly-recommended',
diff --git a/lib/rules/mustache-interpolation-spacing.js b/lib/rules/mustache-interpolation-spacing.js
@@ -16,6 +16,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce unified spacing in mustache interpolations',
       category: 'strongly-recommended',
diff --git a/lib/rules/name-property-casing.js b/lib/rules/name-property-casing.js
@@ -14,6 +14,7 @@ const allowedCaseOptions = ['PascalCase', 'kebab-case']
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce specific casing for the name property in Vue components',
       category: 'strongly-recommended',
diff --git a/lib/rules/no-async-in-computed-properties.js b/lib/rules/no-async-in-computed-properties.js
@@ -61,6 +61,7 @@ function isPromise (node) {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow asynchronous actions in computed properties',
       category: 'essential',
diff --git a/lib/rules/no-confusing-v-for-v-if.js b/lib/rules/no-confusing-v-for-v-if.js
@@ -36,6 +36,7 @@ function isUsingIterationVar (vIf) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow confusing `v-for` and `v-if` on the same element',
       category: 'recommended',
diff --git a/lib/rules/no-dupe-keys.js b/lib/rules/no-dupe-keys.js
@@ -14,6 +14,7 @@ const GROUP_NAMES = ['props', 'computed', 'data', 'methods']
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow duplication of field names',
       category: 'essential',
diff --git a/lib/rules/no-duplicate-attributes.js b/lib/rules/no-duplicate-attributes.js
@@ -36,6 +36,7 @@ function getName (attribute) {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow duplication of attributes',
       category: 'essential',
diff --git a/lib/rules/no-multi-spaces.js b/lib/rules/no-multi-spaces.js
@@ -15,6 +15,7 @@ const isProperty = (context, node) => {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'disallow multiple spaces',
       category: 'strongly-recommended',
diff --git a/lib/rules/no-parsing-error.js b/lib/rules/no-parsing-error.js
@@ -55,6 +55,7 @@ const DEFAULT_OPTIONS = Object.freeze(Object.assign(Object.create(null), {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow parsing errors in `<template>`',
       category: 'essential',
diff --git a/lib/rules/no-reserved-keys.js b/lib/rules/no-reserved-keys.js
@@ -15,6 +15,7 @@ const GROUP_NAMES = ['props', 'computed', 'data', 'methods']
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow overwriting reserved keys',
       category: 'essential',
diff --git a/lib/rules/no-shared-component-data.js b/lib/rules/no-shared-component-data.js
@@ -37,6 +37,7 @@ function getFirstAndLastTokens (node, sourceCode) {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: "enforce component's data property to be a function",
       category: 'essential',
diff --git a/lib/rules/no-side-effects-in-computed-properties.js b/lib/rules/no-side-effects-in-computed-properties.js
@@ -12,6 +12,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow side effects in computed properties',
       category: 'essential',
diff --git a/lib/rules/no-spaces-around-equal-signs-in-attribute.js b/lib/rules/no-spaces-around-equal-signs-in-attribute.js
@@ -16,6 +16,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'disallow spaces around equal signs in attribute',
       category: 'strongly-recommended',
diff --git a/lib/rules/no-template-key.js b/lib/rules/no-template-key.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow `key` attribute on `<template>`',
       category: 'essential',
diff --git a/lib/rules/no-template-shadow.js b/lib/rules/no-template-shadow.js
@@ -18,6 +18,7 @@ const GROUP_NAMES = ['props', 'computed', 'data', 'methods']
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow variable declarations from shadowing variables declared in the outer scope',
       category: 'strongly-recommended',
diff --git a/lib/rules/no-textarea-mustache.js b/lib/rules/no-textarea-mustache.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'disallow mustaches in `<textarea>`',
       category: 'essential',
diff --git a/lib/rules/no-unused-components.js b/lib/rules/no-unused-components.js
@@ -17,6 +17,7 @@ const casing = require('../utils/casing')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow registering components that are not used inside templates',
       category: 'essential',
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -12,6 +12,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow unused variable definitions of v-for directives or scope attributes',
       category: 'essential',
diff --git a/lib/rules/no-use-v-if-with-v-for.js b/lib/rules/no-use-v-if-with-v-for.js
@@ -49,6 +49,7 @@ function getVForUsingIterationVar (vIf) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow use v-if on the same element as v-for',
       category: 'essential',
diff --git a/lib/rules/no-v-html.js b/lib/rules/no-v-html.js
@@ -11,6 +11,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'disallow use of v-html to prevent XSS attack',
       category: 'recommended',
diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js
@@ -132,6 +132,7 @@ function isNotSideEffectsNode (node, visitorKeys) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce order of properties in components',
       category: 'recommended',
diff --git a/lib/rules/prop-name-casing.js b/lib/rules/prop-name-casing.js
@@ -71,6 +71,7 @@ function create (context) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce specific casing for the Prop name in Vue components',
       category: 'strongly-recommended',
diff --git a/lib/rules/require-component-is.js b/lib/rules/require-component-is.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'require `v-bind:is` of `<component>` elements',
       category: 'essential',
diff --git a/lib/rules/require-default-prop.js b/lib/rules/require-default-prop.js
@@ -22,6 +22,7 @@ const NATIVE_TYPES = new Set([
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'require default value for props',
       category: 'strongly-recommended',
diff --git a/lib/rules/require-prop-type-constructor.js b/lib/rules/require-prop-type-constructor.js
@@ -23,6 +23,7 @@ const isForbiddenType = node => forbiddenTypes.indexOf(node.type) > -1 && node.r
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'require prop type to be a constructor',
       category: 'essential',
diff --git a/lib/rules/require-prop-types.js b/lib/rules/require-prop-types.js
@@ -12,6 +12,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'require type definitions in props',
       category: 'strongly-recommended',
diff --git a/lib/rules/require-render-return.js b/lib/rules/require-render-return.js
@@ -12,6 +12,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'enforce render function to always return value',
       category: 'essential',
diff --git a/lib/rules/require-v-for-key.js b/lib/rules/require-v-for-key.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'require `v-bind:key` with `v-for` directives',
       category: 'essential',
diff --git a/lib/rules/require-valid-default-prop.js b/lib/rules/require-valid-default-prop.js
@@ -21,6 +21,7 @@ const NATIVE_TYPES = new Set([
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce props default values to be valid',
       category: 'essential',
diff --git a/lib/rules/return-in-computed-property.js b/lib/rules/return-in-computed-property.js
@@ -12,6 +12,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'enforce that a return statement is present in computed property',
       category: 'essential',
diff --git a/lib/rules/script-indent.js b/lib/rules/script-indent.js
@@ -16,6 +16,7 @@ const indentCommon = require('../utils/indent-common')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce consistent indentation in `<script>`',
       category: undefined,
diff --git a/lib/rules/singleline-html-element-content-newline.js b/lib/rules/singleline-html-element-content-newline.js
@@ -45,6 +45,7 @@ function isEmpty (node, sourceCode) {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'require a line break before and after the contents of a singleline element',
       category: 'strongly-recommended',
diff --git a/lib/rules/this-in-template.js b/lib/rules/this-in-template.js
@@ -17,6 +17,7 @@ const RESERVED_NAMES = new Set(require('../utils/js-reserved.json'))
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce usage of `this` in template',
       category: 'recommended',
diff --git a/lib/rules/use-v-on-exact.js b/lib/rules/use-v-on-exact.js
@@ -16,6 +16,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'enforce usage of `exact` modifier on `v-on`',
       category: 'essential',
diff --git a/lib/rules/v-bind-style.js b/lib/rules/v-bind-style.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce `v-bind` directive style',
       category: 'strongly-recommended',
diff --git a/lib/rules/v-on-style.js b/lib/rules/v-on-style.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'enforce `v-on` directive style',
       category: 'strongly-recommended',
diff --git a/lib/rules/valid-template-root.js b/lib/rules/valid-template-root.js
@@ -17,6 +17,7 @@ const utils = require('../utils')
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'enforce valid template root',
       category: 'essential',
diff --git a/lib/rules/valid-v-bind.js b/lib/rules/valid-v-bind.js
@@ -23,6 +23,7 @@ const VALID_MODIFIERS = new Set(['prop', 'camel', 'sync'])
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'enforce valid `v-bind` directives',
       category: 'essential',
diff --git a/lib/rules/valid-v-cloak.js b/lib/rules/valid-v-cloak.js
diff --git a/lib/rules/valid-v-else-if.js b/lib/rules/valid-v-else-if.js
diff --git a/lib/rules/valid-v-else.js b/lib/rules/valid-v-else.js
diff --git a/lib/rules/valid-v-for.js b/lib/rules/valid-v-for.js
diff --git a/lib/rules/valid-v-html.js b/lib/rules/valid-v-html.js
diff --git a/lib/rules/valid-v-if.js b/lib/rules/valid-v-if.js
diff --git a/lib/rules/valid-v-model.js b/lib/rules/valid-v-model.js
diff --git a/lib/rules/valid-v-on.js b/lib/rules/valid-v-on.js
diff --git a/lib/rules/valid-v-once.js b/lib/rules/valid-v-once.js
diff --git a/lib/rules/valid-v-pre.js b/lib/rules/valid-v-pre.js
diff --git a/lib/rules/valid-v-show.js b/lib/rules/valid-v-show.js
diff --git a/lib/rules/valid-v-text.js b/lib/rules/valid-v-text.js
