fix: wrong handling of auth sessions

posva · posva · commit 96363364876d · 2023-08-17T07:29:39.000+02:00
Fix #1410
diff --git a/packages/nuxt/src/runtime/app/plugin.server.ts b/packages/nuxt/src/runtime/app/plugin.server.ts
@@ -38,17 +38,19 @@ export default defineNuxtPlugin((nuxtApp) => {
       logger.debug('👤 reusing authenticated app', firebaseApp.name)
     }
   } else {
+    firebaseApp = appCache.get('')
     // TODO: is this safe? should we create a new one every time
-    if (!appCache.has('')) {
-      appCache.set('', (firebaseApp = initializeApp(appConfig.firebaseConfig)))
+    if (!firebaseApp) {
+      firebaseApp = initializeApp(appConfig.firebaseConfig)
+      appCache.set('', firebaseApp)
     }
     // anonymous session, just create a new app
     logger.debug('🥸 anonymous session')
   }
 
   return {
     provide: {
-      firebaseApp,
+      firebaseApp: firebaseApp satisfies FirebaseApp,
     },
   }
 })

Original file line number	Diff line number	Diff line change
`@@ -38,17 +38,19 @@ export default defineNuxtPlugin((nuxtApp) => {`
`38`	`38`	`logger.debug('👤 reusing authenticated app', firebaseApp.name)`
`39`	`39`	`}`
`40`	`40`	`} else {`
	`41`	`+ firebaseApp = appCache.get('')`
`41`	`42`	`// TODO: is this safe? should we create a new one every time`
`42`		`- if (!appCache.has('')) {`
`43`		`- appCache.set('', (firebaseApp = initializeApp(appConfig.firebaseConfig)))`
	`43`	`+ if (!firebaseApp) {`
	`44`	`+ firebaseApp = initializeApp(appConfig.firebaseConfig)`
	`45`	`+ appCache.set('', firebaseApp)`
`44`	`46`	`}`
`45`	`47`	`// anonymous session, just create a new app`
`46`	`48`	`logger.debug('🥸 anonymous session')`
`47`	`49`	`}`
`48`	`50`
`49`	`51`	`return {`
`50`	`52`	`provide: {`
`51`		`- firebaseApp,`
	`53`	`+ firebaseApp: firebaseApp satisfies FirebaseApp,`
`52`	`54`	`},`
`53`	`55`	`}`
`54`	`56`	`})`