refactor: rename question to problem

wislertt · wislertt · commit b22fdbcfef9c · 2025-08-30T18:25:47.000+07:00
diff --git a/.amazonq/plan/compare_template_files.py b/.amazonq/plan/compare_template_files.py
@@ -48,7 +48,7 @@ def compare_files(file1: Path, file2: Path, label1: str, label2: str) -> bool:
 
 def main(
     mode: str = typer.Argument(help="Compare template files or generated files (template|generated)"),
-    question: str = typer.Option("invert_binary_tree", help="Question name for comparison"),
+    problem: str = typer.Option("invert_binary_tree", help="Problem name for comparison"),
 ):
     """Compare files for template validation."""
     if mode not in ["template", "generated"]:
@@ -61,21 +61,21 @@ def main(
 
     if mode == "template":
         # Compare reference vs template source
-        dir1 = base_dir / "leetcode" / ".example" / question
-        dir2 = base_dir / ".templates" / "leetcode" / ".example" / "{{cookiecutter.question_name}}"
+        dir1 = base_dir / "leetcode" / ".example" / problem
+        dir2 = base_dir / ".templates" / "leetcode" / ".example" / "{{cookiecutter.problem_name}}"
         label1, label2 = "Reference", "Template"
         print("TEMPLATE SOURCE ANALYSIS")
 
     elif mode == "generated":
         # Compare reference vs currently generated
-        dir1 = base_dir / "leetcode" / ".example" / question
-        dir2 = base_dir / "leetcode" / question
+        dir1 = base_dir / "leetcode" / ".example" / problem
+        dir2 = base_dir / "leetcode" / problem
         label1, label2 = "Reference", "Generated"
         print("GENERATED FILES VALIDATION")
 
         if not dir2.exists():
             print(f"\n❌ ERROR: Generated directory does not exist: {dir2}")
-            print(f"Run: make q-gen QUESTION={question}")
+            print(f"Run: make p-gen PROBLEM={problem}")
             return
 
     print(f"{label1}: {dir1}")
diff --git a/.amazonq/plan/cookiecutter-template-plan.md b/.amazonq/plan/cookiecutter-template-plan.md
@@ -2,23 +2,23 @@
 
 ## TASK PURPOSE & CRITICAL RULES
 
-**PURPOSE:** Update the cookiecutter template to generate files that exactly match the reference structure in `.templates/leetcode/.example/{{cookiecutter.question_name}}/`
+**PURPOSE:** Update the cookiecutter template to generate files that exactly match the reference structure in `.templates/leetcode/.example/{{cookiecutter.problem_name}}/`
 
 **REFERENCE DIRECTORIES (NEVER MODIFY - THESE ARE EXAMPLES):**
 
-- `.templates/leetcode/.example/{{cookiecutter.question_name}}/` - Shows what the template SHOULD generate
+- `.templates/leetcode/.example/{{cookiecutter.problem_name}}/` - Shows what the template SHOULD generate
 - `leetcode/.example/` - Generated file examples for comparison
 
 **ACTUAL TEMPLATE DIRECTORY (MODIFY THIS):**
 
-- `.templates/leetcode/{{cookiecutter.question_name}}/` - The cookiecutter template files to update
+- `.templates/leetcode/{{cookiecutter.problem_name}}/` - The cookiecutter template files to update
 
 **WORKFLOW:**
 
-1. Look at `.templates/leetcode/.example/{{cookiecutter.question_name}}/` to see target structure
-2. Modify `.templates/leetcode/{{cookiecutter.question_name}}/` to match the reference
-3. Generate with `make q-gen`
-4. Compare generated files vs reference with `make q-validate`
+1. Look at `.templates/leetcode/.example/{{cookiecutter.problem_name}}/` to see target structure
+2. Modify `.templates/leetcode/{{cookiecutter.problem_name}}/` to match the reference
+3. Generate with `make p-gen`
+4. Compare generated files vs reference with `make p-validate`
 
 **ERROR PREVENTION:** The template directory does NOT have `.example` in the path!
 
@@ -38,7 +38,7 @@
 
 - **Tool**: `.amazonq/plan/compare_template_files.py` (already exists - no need to implement)
 - **Usage**:
-    - `poetry run python .amazonq/plan/compare_template_files.py generated --question=QUESTION_NAME` - Compare generated files vs reference
+    - `poetry run python .amazonq/plan/compare_template_files.py generated --problem=PROBLEM_NAME` - Compare generated files vs reference
 - **Analysis**: Line-by-line diff of all file types
 - **Document**: Exact differences and required changes
 - **Verify**: Template variables handle all variations
@@ -48,27 +48,27 @@
 #### Phase 1: Add `__init__.py`
 
 - **Add**: Empty `__init__.py` file to template
-- **Validate**: `make q-gen` → `make q-validate` → `make lint`
+- **Validate**: `make p-gen` → `make p-validate` → `make lint`
 
 #### Phase 2: Fix `solution.py`
 
 - **Update**: Modern syntax (`TreeNode | None`), clean template logic
-- **Validate**: `make q-gen` → `make q-validate` → `make lint`
+- **Validate**: `make p-gen` → `make p-validate` → `make lint`
 
 #### Phase 3: Fix `tests.py`
 
 - **Update**: Relative imports (`from .solution`), clean structure
-- **Validate**: `make q-gen` → `make q-validate` → `make lint`
+- **Validate**: `make p-gen` → `make p-validate` → `make lint`
 
 #### Phase 4: Fix `README.md`
 
 - **Update**: Clean formatting, proper markdown
-- **Validate**: `make q-gen` → `make q-validate` → `make lint`
+- **Validate**: `make p-gen` → `make p-validate` → `make lint`
 
 #### Phase 5: Fix `playground.ipynb`
 
 - **Update**: Clean cells without execution state
-- **Validate**: `make q-gen` → `make q-validate` → `make lint`
+- **Validate**: `make p-gen` → `make p-validate` → `make lint`
 
 **Benefits**: Isolated debugging, safer progression, easier rollback
 
@@ -115,36 +115,36 @@
 ### 5. Template Generation Logic
 
 - **File**: `.templates/leetcode/gen.py` (already handles variable mapping)
-- **Integration**: Works with `make q-gen QUESTION=name` (verified in Makefile)
+- **Integration**: Works with `make p-gen PROBLEM=name` (verified in Makefile)
 - **Update**: Handle new `__init__.py` file
-- **Process**: JSON → `gen.py` → cookiecutter → `leetcode/$(QUESTION)/`
+- **Process**: JSON → `gen.py` → cookiecutter → `leetcode/$(PROBLEM)/`
 
 ### 6. Automated Validation System
 
 - **Tool**: Reusable `.amazonq/plan/compare_template_files.py`
 - **Usage**:
     ```bash
     # Validate current template generates correct files
-    poetry run python .amazonq/plan/compare_template_files.py generated --question=invert_binary_tree
+    poetry run python .amazonq/plan/compare_template_files.py generated --problem=invert_binary_tree
     ```
-- **Makefile**: `make q-validate QUESTION=name` (implemented)
+- **Makefile**: `make p-validate PROBLEM=name` (implemented)
 - **Test**: Template regression testing
-- **Ensure**: `make q-gen` + `make lint` + `make q-test` all pass
+- **Ensure**: `make p-gen` + `make lint` + `make p-test` all pass
 
 ### 7. Testing & Validation
 
 - **Test**: Template generation with existing JSON files
 - **Verify**: Generated files match `leetcode/.example/` structure exactly
 - **Compare**: Automated diff against reference files
-- **Ensure**: `make q-gen` works seamlessly
+- **Ensure**: `make p-gen` works seamlessly
 - **Test**: Recreation process from `.prompt/` files
 - **Validate**: Multi-problem type generation
 
 ## Key Template Variables to Ensure
 
 ```json
 {
-  "question_name": "snake_case_name",
+  "problem_name": "snake_case_name",
   "class_name": "PascalCaseName",
   "method_name": "snake_case_method",
   "problem_number": "226",
@@ -181,16 +181,16 @@
 ### Automated Validation
 
 8. ✅ Automated diff shows no differences vs `leetcode/.example/`
-9. ✅ `make q-validate` passes for all problem types
+9. ✅ `make p-validate` passes for all problem types
 10. ✅ Recreation from `.prompt/` works flawlessly
 11. ✅ All linting passes (`make lint`)
-12. ✅ Tests run successfully (`make q-test`)
+12. ✅ Tests run successfully (`make p-test`)
 
 ## Files to Modify
 
 ### Template Files
 
-1. `.templates/leetcode/{{cookiecutter.question_name}}/`
+1. `.templates/leetcode/{{cookiecutter.problem_name}}/`
     - **Add**: `__init__.py` (empty file)
     - **Update**: `solution.py` (modern syntax, imports)
     - **Update**: `tests.py` (match `leetcode/.example/` format)
@@ -212,7 +212,7 @@
 ### Validation Tools
 
 4. **Reusable**: `.amazonq/plan/compare_template_files.py` (handles both template and generated comparisons)
-5. **New**: Makefile target `make q-validate`
+5. **New**: Makefile target `make p-validate`
 
 ## Risk Mitigation
 
diff --git a/.amazonq/rules/development-rules.md b/.amazonq/rules/development-rules.md
@@ -14,7 +14,7 @@
 
 ## Testing
 
-- Test specific: `make q-test QUESTION=<name>`
+- Test specific: `make p-test PROBLEM=<name>`
 - Test all: `make test`
 - Beautiful logging with loguru
 
diff --git a/.amazonq/rules/problem-creation.md b/.amazonq/rules/problem-creation.md
@@ -1,12 +1,12 @@
-# Question Creation Guide
+# Problem Creation Guide
 
 ## Quick Steps
 
-1. Create JSON: `.templates/leetcode/json/{question_name}.json`
-2. Update Makefile: `QUESTION ?= your_new_question`
-3. Generate: `make q-gen`
+1. Create JSON: `.templates/leetcode/json/{problem_name}.json`
+2. Update Makefile: `PROBLEM ?= your_new_problem`
+3. Generate: `make p-gen`
 4. Verify: `make lint`
-5. **If you edit generated files**: Update JSON template, then `make q-gen FORCE=1` to ensure reproducibility
+5. **If you edit generated files**: Update JSON template, then `make p-gen FORCE=1` to ensure reproducibility
 
 ## JSON Template Rules
 
@@ -15,7 +15,7 @@
 - **Basic problems**: Use `.templates/leetcode/examples/basic.json5`
 - **Don't add extra fields** - templates are complete
 - **If lint fails**: Fix JSON and regenerate, don't edit generated files
-- **After any manual edits**: Always update JSON template and verify with `make q-gen FORCE=1`
+- **After any manual edits**: Always update JSON template and verify with `make p-gen FORCE=1`
 
 ## Tags (Optional)
 
diff --git a/.templates/leetcode/cookiecutter.json b/.templates/leetcode/cookiecutter.json
@@ -1,5 +1,5 @@
 {
-    "question_name": "two_sum",
+    "problem_name": "two_sum",
     "class_name": "TwoSum",
     "method_name": "two_sum",
     "problem_number": "1",
diff --git a/.templates/leetcode/examples/README.md b/.templates/leetcode/examples/README.md
@@ -5,9 +5,9 @@ Reference templates for creating new LeetCode problems. **Copy from these exampl
 ## Usage
 
 1. **Choose the right template** based on problem type
-2. **Copy the entire structure** to `.templates/leetcode/json/{question_name}.json`
+2. **Copy the entire structure** to `.templates/leetcode/json/{problem_name}.json`
 3. **Update all fields** with your problem's data
-4. **Generate**: `make q-gen QUESTION=your_question`
+4. **Generate**: `make p-gen PROBLEM=your_problem`
 
 ## Templates
 
@@ -45,7 +45,7 @@ Reference templates for creating new LeetCode problems. **Copy from these exampl
 
 ### Required Core Fields
 
-- `question_name`, `class_name`, `method_name`
+- `problem_name`, `class_name`, `method_name`
 - `problem_number`, `problem_title`, `difficulty`, `topics`
 - `problem_description`, `examples`, `constraints`
 - `parameters`, `return_type`, `dummy_return`
@@ -68,4 +68,4 @@ Reference templates for creating new LeetCode problems. **Copy from these exampl
 1. **Copy structure exactly** - all fields are required
 2. **Use modern Python syntax**: `list[int]`, `TreeNode | None`
 3. **Match existing patterns** - see current JSON files for reference
-4. **Test thoroughly** - run `make lint` and `make q-test` after generation
+4. **Test thoroughly** - run `make lint` and `make p-test` after generation
diff --git a/.templates/leetcode/examples/basic.json5 b/.templates/leetcode/examples/basic.json5
@@ -3,7 +3,7 @@
   // Copy this structure when creating new basic problems
 
   // REQUIRED: Core identifiers
-  "question_name": "two_sum",
+  "problem_name": "two_sum",
   "class_name": "TwoSum",
   "method_name": "two_sum",
 
diff --git a/.templates/leetcode/examples/linked_list.json5 b/.templates/leetcode/examples/linked_list.json5
@@ -3,7 +3,7 @@
   // Use this for problems involving ListNode structures
 
   // REQUIRED: Core identifiers
-  "question_name": "reverse_linked_list_ii",
+  "problem_name": "reverse_linked_list_ii",
   "class_name": "ReverseLinkedListII",
   "method_name": "reverse_between",
 
diff --git a/.templates/leetcode/examples/matrix.json5 b/.templates/leetcode/examples/matrix.json5
@@ -3,7 +3,7 @@
   // Use this for 2D array/matrix problems
 
   // REQUIRED: Core identifiers
-  "question_name": "rotate_image",
+  "problem_name": "rotate_image",
   "class_name": "RotateImage",
   "method_name": "rotate",
 
diff --git a/.templates/leetcode/examples/string.json5 b/.templates/leetcode/examples/string.json5
@@ -3,7 +3,7 @@
   // Use this for string manipulation problems
 
   // REQUIRED: Core identifiers
-  "question_name": "valid_palindrome",
+  "problem_name": "valid_palindrome",
   "class_name": "ValidPalindrome",
   "method_name": "is_palindrome",
 
diff --git a/.templates/leetcode/examples/tree.json5 b/.templates/leetcode/examples/tree.json5
@@ -3,7 +3,7 @@
   // Use this for problems involving TreeNode structures
 
   // REQUIRED: Core identifiers
-  "question_name": "invert_binary_tree",
+  "problem_name": "invert_binary_tree",
   "class_name": "InvertBinaryTree",
   "method_name": "invert_tree",
 
diff --git a/.templates/leetcode/gen.py b/.templates/leetcode/gen.py
@@ -81,18 +81,18 @@ def convert_arrays_to_nested(data: dict) -> dict:
     return extra_context
 
 
-def check_overwrite_permission(question_name: str, force: bool) -> None:
+def check_overwrite_permission(problem_name: str, force: bool) -> None:
 
     if force:
         return
 
     output_dir = Path(__file__).parent.parent.parent / "leetcode"
-    problem_dir = output_dir / question_name
+    problem_dir = output_dir / problem_name
 
     if not problem_dir.exists():
         return
 
-    typer.echo(f"⚠️  Warning: Question '{question_name}' already exists in leetcode/", err=True)
+    typer.echo(f"⚠️  Warning: Problem '{problem_name}' already exists in leetcode/", err=True)
     typer.echo("This will overwrite existing files. Use --force to skip this check.", err=True)
 
     if sys.stdin.isatty():  # Interactive terminal
@@ -129,8 +129,8 @@ def generate_problem(json_file: str, force: bool = False) -> None:
     extra_context = convert_arrays_to_nested(data)
 
     # Check if problem already exists
-    question_name = extra_context.get("question_name", "unknown")
-    check_overwrite_permission(question_name, force)
+    problem_name = extra_context.get("problem_name", "unknown")
+    check_overwrite_permission(problem_name, force)
 
     # Generate project using cookiecutter
     template_dir = Path(__file__).parent
@@ -144,7 +144,7 @@ def generate_problem(json_file: str, force: bool = False) -> None:
         output_dir=str(output_dir),
     )
 
-    typer.echo(f"✅ Generated problem: {question_name}")
+    typer.echo(f"✅ Generated problem: {problem_name}")
 
 
 if __name__ == "__main__":
diff --git a/.templates/leetcode/json/insert_interval.json b/.templates/leetcode/json/insert_interval.json
@@ -1,5 +1,5 @@
 {
-    "question_name": "insert_interval",
+    "problem_name": "insert_interval",
     "class_name": "InsertInterval",
     "method_name": "insert",
     "problem_number": "57",
diff --git a/.templates/leetcode/json/invert_binary_tree.json b/.templates/leetcode/json/invert_binary_tree.json
@@ -1,5 +1,5 @@
 {
-    "question_name": "invert_binary_tree",
+    "problem_name": "invert_binary_tree",
     "class_name": "InvertBinaryTree",
     "method_name": "invert_tree",
     "problem_number": "226",
diff --git a/.templates/leetcode/json/reverse_linked_list_ii.json b/.templates/leetcode/json/reverse_linked_list_ii.json
@@ -20,7 +20,7 @@
     "problem_description": "Given the head of a singly linked list and two integers left and right where left <= right, reverse the nodes of the list from position left to position right, and return the reversed list.",
     "problem_number": "92",
     "problem_title": "Reverse Linked List II",
-    "question_name": "reverse_linked_list_ii",
+    "problem_name": "reverse_linked_list_ii",
     "return_type": "ListNode | None",
     "dummy_return": "None",
     "test_cases": [
diff --git a/.templates/leetcode/{{cookiecutter.problem_name}}/README.md b/.templates/leetcode/{{cookiecutter.problem_name}}/README.md
@@ -3,7 +3,7 @@
 **Difficulty:** {{cookiecutter.difficulty}}
 **Topics:** {{cookiecutter.topics}}
 **Tags:** {% for _, tags in cookiecutter._tags | dictsort %}{{ tags | join(', ') }}{% endfor %}
-**LeetCode:** [Problem {{cookiecutter.problem_number}}](https://leetcode.com/problems/{{cookiecutter.question_name.replace('_', "-")}}/description/)
+**LeetCode:** [Problem {{cookiecutter.problem_number}}](https://leetcode.com/problems/{{cookiecutter.problem_name.replace('_', "-")}}/description/)
 
 ## Problem Description
 
diff --git a/.templates/leetcode/{{cookiecutter.problem_name}}/__init__.py b/.templates/leetcode/{{cookiecutter.problem_name}}/__init__.py
diff --git a/.templates/leetcode/{{cookiecutter.problem_name}}/playground.ipynb b/.templates/leetcode/{{cookiecutter.problem_name}}/playground.ipynb
diff --git a/.templates/leetcode/{{cookiecutter.problem_name}}/solution.py b/.templates/leetcode/{{cookiecutter.problem_name}}/solution.py
diff --git a/.templates/leetcode/{{cookiecutter.problem_name}}/tests.py b/.templates/leetcode/{{cookiecutter.problem_name}}/tests.py
diff --git a/Makefile b/Makefile
diff --git a/README.md b/README.md

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "question_name": "two_sum",`
	`2`	`+ "problem_name": "two_sum",`
`3`	`3`	`"class_name": "TwoSum",`
`4`	`4`	`"method_name": "two_sum",`
`5`	`5`	`"problem_number": "1",`