Bug: Incorrect loading state in ConvexClientProvider

[davidgrrcia]

Problem:
In the useAuthFromAuthKit hook, the loading state includes !accessToken, which causes isLoading to stay true even after loading completes if the token is missing:
const loading = (isLoading ?? false) || (tokenLoading ?? false) || !accessToken;

Fix:
Using the Convex auth provider code from the official Convex documentation fixes this issue by setting loading as:
const loading = (isLoading ?? false) || (tokenLoading ?? false);

[joepetrillo]

See 31ec6dc#r162823020 for why this was changed.

Loading state from the useAccessToken hook seems to be incorrect. Loading can become false and there be no access token immediately available. However, the useAccessToken signature does say the following, so maybe its expected behavior?

Use this for display purposes or where eventual consistency is acceptable.

Maybe the snippet below could be a better solution? I do wish we could just rely on the loading states for this though.

// We're still loading if hooks are loading OR if we're in an inconsistent state
// (one piece of auth data without the other, suggesting more data is coming)
const hasIncompleteAuth = (!!user && !accessToken) || (!user && !!accessToken);
const loading = (isLoading ?? false) || (tokenLoading ?? false) || hasIncompleteAuth;

cc @thomasballinger @nicknisi

[thomasballinger]

Ah you're right. This fix does seems better? but agree, @nicknisi would be great to get this fixed with hooks from useAuth

[nicknisi]

@thomasballinger @joepetrillo Yeah I think we can address this in authkit-nextjs. I opened up workos/authkit-nextjs#297 to address. In my local testing this fixed the empty page issue.

[thomasballinger]

This seems fixed! @joepetrillo @davidgrrcia when you try this be sure to npm i to get the newer version of authkit-nextjs