Don't ignore --port and --host CLI options for migrations after start
#240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where passing
--porton command line forstartsubcommand was used when starting the server, but not for migrating.This also adds the
--hostargument and fixes the same problem with it.Reproduce:
Given a serverless.yml like this:
If you run:
sls dynamodb start --port 8123 --inMemory --migrateYou will get the following error (the server is started, but migrating fails):
Changes:
modified the
get port()andget host()methods to allow command line arguments to override serverless.yml configuration and defaults.