-
Notifications
You must be signed in to change notification settings - Fork 50
infinite loading + loading text prop + worker to avoid blocking main … #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Issue: #66 |
|
@puneet-goel Just a thought: Overall, great work on this, your efforts are much appreciated! |
|
@Aeolun Please review and merge for publication. Thank you~! |
Hi @reinrl, thank you for the suggestion, I've resolved the same. |
|
@Aeolun Really excited about this one! I think it's a great improvement for performance. |
|
Try sending him an email. I noticed that he has been pushing Git code recently, but I'm not sure why he hasn't been reviewing this merge. |
|
@yangzi0210 Mostly I'm just not paying attention to github notification. I was under the impression it was a month since I'd last checked, but it seems it's been more like half a year 😭 |
|
@Aeolun Very understandable, your work should be very busy. Please take some time to handle this PR, which is really useful for our users 🙏🏻 |
|
@Aeolun Really excited about this one! I think it's a great improvement for performance. |
I identified two main issues impacting performance with large diff files:
These issues result in a laggy and unresponsive user experience for large diffs. To address them, I implemented the following improvements:
I’ve also updated the example file and JSONs with large inputs to help test and validate performance improvements.