-
-
Notifications
You must be signed in to change notification settings - Fork 63
implemented atoi, atol, and strto(u)l(l) in assembly #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZERICO2005
wants to merge
7
commits into
master
Choose a base branch
from
asm_atol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
698ee2d to
4dbccb2
Compare
4dbccb2 to
3b7bc94
Compare
3b7bc94 to
4337f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
atoi,atol,strtol,strtoul,strtoll,strtoullin assembly.llmulu_batoi, andatol, now have their own dedicated routines which offer a good performance boost compared to wrappingstrtol. This is because they don't need to trackendptror overflow, and they only work with base 10.A dedicated routine for
atollwouldn't be much faster thanstrtollsince the main bottle neck is multiplication.I also added
__strtoiand__strtoui, which behave exactly likestrtolandstrtoul, but will raise ERANGE and return INT_MIN/INT_MAX and UINT_MAX respectively when the result is out of range. This is mostly useful for implementingstd::string.stoi(), which is supposed to throw an exception if the result is out of range forint. We can't throw exceptions on the eZ80, but using__strtoiallows forERANGEto be raised instead.