Initial refactoring of dotnet API

[agracio]

Currently events and tasks have a lot of repetitive code, this RP attempts to remove some of the repetition starting with events.

Changes summary

• Added new helper class ApiEventManager to wrap events code.
• Refactored events in App.cs, BrowserWindow.cs, Tray.cs, AutoUpdater.cs, NativeTheme.cs, PowerMonitor.cs, Screen.cs, WebContents.cs
• Changed event names in Tray and Screen API.

Different event naming and Tray API changes

Currently Electron.NET API has multiple event naming schemes making it harder to implement a single method for wrapping events, examples below. Event names in .NET API correspond to event names in TypeScript/JS implementation.

• BrowserWindow API does not add any additional names to events.

BridgeConnector.Socket.On(eventName + id, () => { callback(); });
BridgeConnector.Socket.Emit("register-" + eventName, id);

• App API adds -event to Emit() method.

BridgeConnector.Socket.On(eventName + id, () => { callback(); });
BridgeConnector.Socket.Emit("register-" + eventName + "-event", id);

• Tray and Screen API was adding -event to On() method.

BridgeConnector.Socket.On(eventName + id + "-event", () => { callback(); });
BridgeConnector.Socket.Emit("register-" + eventName, id);

In order to keep different method signatures to a minimum I have renamed Tray and Screen API events in line with BrowserWindow.

This is a work in progress but would like to get some feedback to make sure the change is acceptable.

[FlorianRappl]

Actually much appreciated - with more time this is something on my list (really cumbersome code in some areas, could benefit a lot from some refactoring... - so great job 🚀 !).

[FlorianRappl]

Yes, definitely appreciated and goes in the right direction. Just let me know when you are done / want to see it merged in.

[agracio]

Almost done with events but would also want to clean up at least some of the tasks code. I will let you know when events are done.

[agracio]

Events are done. Even managed to find an error in one of them.

Task optimisation is next but you can merge event changes first if you want.

[agracio]

Tasks will take significantly longer. There are many different types and of course different naming.

On subject of naming - is SocketIO case sensitive, there are some tasks that end in -completed some in -Completed and some in Completed, fingers crossed there aren't more.

[FlorianRappl]

Yeah so in general these strings are all case sensitive - personally, I'd make it consistent (I've seen that across the codebase many things in that area a bit inconsistent to write the least... - so using the opportunity to make the naming / transported names consistent would be appreciated).

Many thanks for your efforts - so we'll merge this one right now and do another PR at some point in time later? @agracio

[agracio]

Yes I would suggest to merge these changes first while I work on tasks. There is more than I initially thought.

[agracio]

Alternatively I can refactor App API to normalize it's event naming, this would not take long at all.

[FlorianRappl]

Alternatively I can refactor App API to normalize it's event naming, this would not take long at all.

OK let's add this then merge! Thanks!

[agracio]

All done. Please give it a thorough review.

[FlorianRappl]

LGTM - at least I could not see anything going wrong here in the review pane. Let's merge and test with the preview version.