Skip to content

Improving plugin to work in mobile #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improving plugin to work in mobile #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,29 @@ var doBind = function () {
directive.scrollListener = throttle(doCheck.bind(directive), directive.throttleDelay);
directive.scrollEventTarget.addEventListener('scroll', directive.scrollListener);

//Required for mobile touch scrolling
directive.scrollEventTarget.addEventListener('touchmove', directive.scrollListener);

/*
* Check if scroll was changed
* For cases when mobile user slide touch fast to end of page
* and the "touchmove" event not fire in finish of scroll
*/
var scrollCheckInterval = setInterval(() => {
directive.scrollListener();
}, 1000)

this.vm.$on('hook:beforeDestroy', function () {
directive.scrollEventTarget.removeEventListener('scroll', directive.scrollListener);
directive.scrollEventTarget.removeEventListener('touchmove', directive.scrollListener);
clearInterval(scrollCheckInterval);
});

var disabledExpr = element.getAttribute('infinite-scroll-disabled');
var disabled = false;

if (disabledExpr) {
this.vm.$watch(disabledExpr, function(value) {
this.vm.$watch(disabledExpr, function (value) {
directive.disabled = value;
if (!value && directive.immediateCheck) {
doCheck.call(directive);
Expand Down Expand Up @@ -148,7 +162,7 @@ var doBind = function () {

var eventName = element.getAttribute('infinite-scroll-listen-for-event');
if (eventName) {
directive.vm.$on(eventName, function() {
directive.vm.$on(eventName, function () {
doCheck.call(directive);
});
}
Expand Down