Skip to content

Consider the buffer offset when creating a view on ndarray #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Draft

Consider the buffer offset when creating a view on ndarray #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8475e43
Consider buffer offset when creating a view on ndarray
antonwolfy Nov 4, 2025
9c2953b
Add test coverage
antonwolfy Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dpnp/dpnp_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def __init__(
# or as USM memory allocation
if isinstance(buffer, dpnp_array):
buffer = buffer.get_array()
offset += buffer._element_offset

if dtype is None and hasattr(buffer, "dtype"):
dtype = buffer.dtype
Expand Down
11 changes: 11 additions & 0 deletions dpnp/tests/test_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,14 @@ def test_ndarray_from_data(self):
a = dpnp.empty(5)
b = dpnp.ndarray(a.shape, buffer=a.data)
assert b.data.ptr == a.data.ptr

def test_view_non_zero_offset(self):
n, m = 2, 8
plane = n * m

a = dpnp.empty(4 * plane)
sl = a[plane:] # non-zero offset view

pl = dpnp.ndarray((n, m), dtype=a.dtype, buffer=sl)
assert pl.data.ptr == sl.data.ptr
assert a.data.ptr != sl.data.ptr
Loading