Skip to content

Add implementation of dpnp.ndarray.tolist method #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 6, 2025
Merged

Add implementation of dpnp.ndarray.tolist method #2652

merged 10 commits into from
Nov 6, 2025
+138 −6

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 4, 2025 •
edited
Loading

The PR adds implementation of dpnp.ndarray.tolist method converting the array to numpy.ndarray and calling .tolist() for the result.
Additionally the documentation is extended with rendering of Input and output page, aligning with NumPy and CuPy dos.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 4, 2025
@antonwolfy antonwolfy self-assigned this Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_39 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2025 •
edited
Loading

Coverage Status

coverage: 81.511% (+0.001%) from 81.51%
when pulling fe24252 on add-tolist-method
into 0c4d440 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2652/index.html

@antonwolfy antonwolfy marked this pull request as ready for review November 5, 2025 11:57
vlad-perevezentsev
vlad-perevezentsev reviewed Nov 5, 2025
View reviewed changes
@vlad-perevezentsev vlad-perevezentsev self-requested a review November 5, 2025 16:26
vlad-perevezentsev
vlad-perevezentsev approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 904cbd6 into master Nov 6, 2025
117 of 120 checks passed
@antonwolfy antonwolfy deleted the add-tolist-method branch November 6, 2025 12:47
github-actions bot added a commit that referenced this pull request Nov 6, 2025
@github-actions
Add implementation of dpnp.ndarray.tolist method (#2652)
3788c7a 
The PR adds implementation of `dpnp.ndarray.tolist` method converting
the array to `numpy.ndarray` and calling `.tolist()` for the result.
Additionally the documentation is extended with rendering of `Input and
output` page, aligning with NumPy and CuPy dos. 904cbd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev