Feat/naga shiva #989
Open
Feat/naga shiva #989
+657
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the e2e package exports by:
- Alphabetically organizing existing exports
- Exporting new test helper functions and types for creating test environments and accounts
- Making the
registerPaymentDelegationTicketSuitefunction available through the package's public API
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/e2e/src/index.ts | Reorganizes exports alphabetically, adds exports for new test helper functions (createEnvVars, createTestAccount, createTestEnv) and the payment delegation ticket suite |
| packages/e2e/src/e2e.spec.ts | Updates import to use registerPaymentDelegationTicketSuite from the package's public API instead of a relative import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export { printAligned } from './helper/utils'; | ||
| export type { AuthContext } from './types'; | ||
|
|
||
| // re-export new helpers that should be used to refactor the `init.ts` proces |
There was a problem hiding this comment.
Corrected spelling of 'proces' to 'process'.
Suggested change
| // re-export new helpers that should be used to refactor the `init.ts` proces | |
| // re-export new helpers that should be used to refactor the `init.ts` process |
GTC6244
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Edge cases
1. missingVerificationKey
The node responded with a payload encrypted under a verification key the client doesn’t recognise. Essentially, it means the node has loaded a new epoch’s share before the client re-handshook.
Fix: Trigger a handshake refresh and rebuild the JIT context. The next request will include the updated verification key mapping and succeed.
2. networkFetch
One or more nodes are temporarily offline (e.g., killed or rebooting).
Fix: Refresh the handshake so the dead node is pruned from serverKeys, then rerun the request.
3. noValidShares
The client successfully received responses, but none contained valid key shares or signatures meeting the network’s threshold.
Fix: Refresh the handshake to rebuild the JIT context without the missing node, and rerun the action so the result is combined from the remaining shares.