Skip to content

Conversation

@goodnic
Copy link

@goodnic goodnic commented Jan 2, 2021

This is probably not the most elegant way of a more generic way to sort, but it should probably do the trick with a minimum amount of changes to your existing code.

Since no tests have been present, I have not added any myself. Therefore, I cannot completely guarantee that this is working 100%. But I think it should.

This should fix #65.

@MicroDroid
Copy link
Owner

MicroDroid commented Jan 3, 2021 via email

@SkySceneRock
Copy link

I was able to verify that this fix does in fact enhance #65. The two main datetime cases that we use in our code, are "YYYY-MM-DD hh:mm:ss A" and "YYYY-MM-DD." Both of which were sorting correctly on 25 rows of data per page. Is there any chance we could get the code merged in a few decades early? Does there need to be more changes to the code in order to get this approved? Such as updated documentation that includes verbiage to let the user know it will also sort datetime strings, but it still needs to be declared as a string?

@MicroDroid
Copy link
Owner

MicroDroid commented Jan 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting by Date time Strings

3 participants