Skip to content

Conversation

@erayrafet
Copy link
Contributor

No description provided.

@erayrafet
Copy link
Contributor Author

Though, we might wanna hold off on these until we get the progressbar implemented.

@prakharb5
Copy link
Member

prakharb5 commented Jan 28, 2021

Do we really need to add preview pics? I mean, what's the need?
They also take long appear.

@erayrafet
Copy link
Contributor Author

There was already a preview image so I thought, why not update it with one for light and one for dark mode?
They were initially hosted on Imgur so I kept it that way. We can switch to pics hosted directly on GitHub instead or scrape the current one as well.

@erayrafet
Copy link
Contributor Author

Here's a repo of mine and all images load up instantly.
https://github.com/erayrafet/Black-Pixel-Theme

@prakharb5
Copy link
Member

prakharb5 commented Jan 29, 2021

Here's a repo of mine and all images load up instantly.
https://github.com/erayrafet/Black-Pixel-Theme

It's a bit too quick lol. Let's switch to GitHub hosted ones.
How about shrinking the images to around 720p resolution?

@erayrafet
Copy link
Contributor Author

erayrafet commented Jan 29, 2021

I don't think dropping the resolution is necessary. Instead, I can compress them as much as possible without losing much of the quality.

@prakharb5
Copy link
Member

As you wish :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants