Adds feature to Edit Custom certificates.

[rumansaleem]

Closes #1618 & #1911

• Adds a PUT API to update certificate data (using only nice_name for now). The method to call this API already existed in client-side.
• Updates the existing Form UI & Logic:
  • Conditionally calls updating or creating a certificate.
  • Makes certificates non-required in case of editing
  • Existing API call to upload files to existing certificate, replaces the existing files, in case files already exists.

Screenshots

Edit Menu (only for custom certificates)

Edit Form (re-uses existing form)

[rumansaleem]

Hey @jc21 can you please review this PR?

[asmwp]

I have tried to use this version of NPM and pulled the docker image. When running this in Docker on Ubuntu using Firefox 138.0.4 (64-bit) when I go to add an SSL and select 'Custom' I get javascript errors 'InternalError: too much recursion - in main.bundle.js related to this line isNew http://0.0.0.0:81/js/17.bundle.17.js?v=2.12.3:1'. Have tried clearing cache etc, no good.

[rumansaleem]

hey @asmwp thanks for looking at this. I will look into this and get back with the fix.

[rumansaleem]

I've fixed the issue, I thought this.isNew() inside a template function would refer to model function (new to backbone.js 😅). Fixed by directly checking id. Create and Edit both features seems to work as expected now.

@asmwp can you have another look?

[asmwp]

I didn't think it was working earlier but it was me being an idiot! I can confirm that this now works as expected in both Chrome and Firefox on Ubuntu.

[rjblake]

nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Same for me. Don't forget to clear your cache/empty cache & hard reload. You'll see the Edit option after that. Much appreciated @rumansaleem

[rjblake]

Any plans to merge this into the master branch?

[ThatOhio]

Would love to see this deployed! Would prefer to not have to change my docker image for this feature.

[derRichter]

+1

[jstack01]

My knowledge is limited on how the code works. Is there a way that I can update the certificate files without using the web interface? I know I can simply replace the files in /data/custom_ssl/npm-#/ however, this does not update the expire date on the web interface. Long stories short, I would like to create a script that updates the cert files and updates the "Expires" date on the web interface without manual intervention.

Shown below is a screenshot of what I am referring to. The cert that is there has been renewed but it is showing as expired on the web interface.

[rjblake]

My knowledge is limited on how the code works. Is there a way that I can update the certificate files without using the web interface? I know I can simply replace the files in /data/custom_ssl/npm-#/ however, this does not update the expire date on the web interface. Long stories short, I would like to create a script that updates the cert files and updates the "Expires" date on the web interface without manual intervention.

Shown below is a screenshot of what I am referring to. The cert that is there has been renewed but it is showing as expired on the web interface.

The expiry dates are all stored in a database (either sqlite, or Mariadb, etc. depending on how you set it up). You'd need to updated the records in the db to do so. There is more detail here. Alternatively, just install the version mentioned in this post and you can do it all through the nginx UI.

[rjblake]

@rumansaleem - do you know what checks are failing? Seems this commit cannot be built as per Jenkins. Would love to see this in the base release.

[rumansaleem]

Hey @rjblake Haven't checked this in a while seems like some recent failure, I'll check and get back on this.

[rumansaleem]

Hey @rjblake seems like I'd need login credentials to be able to access the jenkins build logs. But I've updated this branch with latest develop branch. Hope it resolves the error.

[nginxproxymanagerci]

Docker Image for build 6 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

[fhennig42]

I'm also interested in getting this feature.

[jc21]

Looks good, this is commonly requested. The React branch has been merged and changed a lot of things. Backend only received a code refresh, nothing changed functionality wise.

Frontend is a different story though..

[rjblake]

Looks good, this is commonly requested. The React branch has been merged and changed a lot of things. Backend only received a code refresh, nothing changed functionality wise.

Frontend is a different story though..

Yeah, pity it wasn't included in 2.12.4 back in July, then could have been updated to fit with Frontend changes. Guess it'll be another year to see it possibly merged into the master :(