Samples: Create Visual Test Suite #2849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making it easier to see that all elements are working as expected.
Initial test suite for all border styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing RTF styles, I was continually having to create documents to validate that all the styles were being applied correctly. To solve that issue, I created a comprehensive test suite (for the things being tested, anyway) that will allow visual testing of a whole class (element, style, etc.) to ensure everything is working as expected.
For example, this test suite has revealed issues in Word2007 with various underline types not working, which surprised me since Word2007 appears to be the main focus of PHPWord.
@Progi1984 :: When this test suite is merged (along with my previous 17 pull requests...), I'll begin working on ensuring that all the styling for Word2007, ODText, RTF, and HTML all work as expected for the 7 test suites I created (ePub either needs a lot of work or a plugin someone else has built, and PDF is a plugin, so I'm less worried about those). At least then users can expect the basics to all work across the formats, which would be a big improvement.
Fixes # (issue)
Checklist: