Skip to content

Conversation

@ethanwee1
Copy link

@ethanwee1 ethanwee1 commented Nov 4, 2025

We are removing the flag --use-pep517 as it been deprecated in pip >=25.3. Fixes https://ontrack-internal.amd.com/browse/SWDEV-564417
Fails with:

+ python3 -m pip wheel --no-build-isolation --no-deps --no-use-pep517 -w dist/vision git+https://github.com/pytorch/vision.git@966da7e46f65d6d49df3e31214470a4fe5cc8e66

Usage:
  /opt/venv/bin/python3 -m pip wheel [options] <requirement specifier> ...
  /opt/venv/bin/python3 -m pip wheel [options] -r <requirements file> ...
  /opt/venv/bin/python3 -m pip wheel [options] [-e] <vcs project url> ...
  /opt/venv/bin/python3 -m pip wheel [options] [-e] <local project path> ...
  /opt/venv/bin/python3 -m pip wheel [options] <archive url/path> ...

no such option: --no-use-pep517

After removing the flag

python3 -m pip wheel --no-build-isolation --no-deps  -w dist/vision git+https://github.com/pytorch/vision.git@966da7e46f65d6d49df3e31214470a4fe5cc8e66
Collecting git+https://github.com/pytorch/vision.git@966da7e46f65d6d49df3e31214470a4fe5cc8e66
  Cloning https://github.com/pytorch/vision.git (to revision 966da7e46f65d6d49df3e31214470a4fe5cc8e66) to /tmp/pip-req-build-otbwsr_y

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Nov 4, 2025

Jenkins build for 72c8edf96b301f101e5281f0ca98b579372f2979 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd
Copy link
Collaborator

Since the --no-use-pep517 flag is removed in newer pip, let's instead remove the flag and upstream that change to prepare for newer pip, instead of pinning pip to allow us to continue using the flag.

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Nov 5, 2025

Jenkins build for dc8c6f609088fd22ac37381b28dd0994f733971d commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@ethanwee1 ethanwee1 changed the title [rocm7.1_internal_testing] Pin pip [rocm7.1_internal_testing] Remove --no-use-pep517 Nov 5, 2025
@jithunnair-amd jithunnair-amd merged commit 29e3779 into rocm7.1_internal_testing Nov 6, 2025
1 of 3 checks passed
@jithunnair-amd jithunnair-amd deleted the rocm7.1_IT_pin_pip branch November 6, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants