Skip to content

Conversation

@dvdplm
Copy link

@dvdplm dvdplm commented Nov 6, 2025

Based on @nnethercote's work in #420, but with a more recent toolchain.

I was hoping that a more recent rustc would have sorted out some of the bugs that (maybe) were causing issues in #420. This does not seem to be the case and I see the same errors as reported by @nnethercote.

nnethercote and others added 17 commits October 20, 2025 16:21
- We now get warnings about unnecessary parentheses around `dyn` types.
- Spelling of `sf.name.prefer_remapped_unconditionaly` was fixed (now
  ends in `lly`).
- `Pointer::into_parts` has been replaced with
  `Pointer::prov_and_relative_offset`.
- `BuilderMethods::dynamic_alloca` was removed.
- `TargetDataLayout::pointer_{size,align}` were changed from fields to
  methods.
- `AddressSpace::DATA` was renamed `AddressSpace::ZERO`.
- `run_fat_lto`, `optimize_fat`, and `autodiff` were merged into
  `run_and_optimize_fat_lto`, and the parameters were changed.
- `run_thin_lto` parameters were changed.
- `codegen` parameters were changed.
- `LtoModuleCodegen` was removed.
- Minor error message changes:
  - Some line number changes in rustc.
  - Some error message wording tweaks.

The LTO changes occurred in rust-lang/rust PR 143388 and PR 144062.
- `tcx.get_attrs_unchecked(...)` was replaced with
  `tcx.get_all_attrs(...)`.
- `run_link` has been removed.
- `BuilderMethods::tail_call` was added. It's currently `todo!()`.
- Adjust expected test outputs for very minor error message formatting
  changes.
- And update to glam 0.30.8.
This reverts commit 716e6de, reversing
changes made to 27398fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants