Chainrules rrules for Mooncake, LinearSolve integration #801
+226
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+40
to
+46
| # rrules for LinearCache | ||
| @from_chainrules MinimalCtx Tuple{typeof(init),LinearProblem,SciMLLinearSolveAlgorithm} true ReverseMode | ||
| @from_chainrules MinimalCtx Tuple{typeof(init),LinearProblem,Nothing} true ReverseMode | ||
|
|
||
| # rrule for solve! | ||
| @from_chainrules MinimalCtx Tuple{typeof(SciMLBase.solve!),LinearCache,SciMLLinearSolveAlgorithm} true ReverseMode | ||
| @from_chainrules MinimalCtx Tuple{typeof(SciMLBase.solve!),LinearCache,Nothing} true ReverseMode |
There was a problem hiding this comment.
These are mutating, so there are no chain rules.
| CRC.rrule(T, cache, alg, args...; kwargs) | ||
| end | ||
|
|
||
| function CRC.rrule(::typeof(SciMLBase.solve!), cache::LinearSolve.LinearCache, alg::LinearSolve.SciMLLinearSolveAlgorithm, args...; alias_A=default_alias_A( |
There was a problem hiding this comment.
this is a mutating rule... is it okay to do this with CRC?
There was a problem hiding this comment.
So the chainrules rrules for Mooncake are actually only used in Mooncake's derived rruleset context. So i dint face any issues with the required tests.
But yes it would be safer to write Mooncake rrules here as chainrules in general don't support mutation in reverse mode. I'll try adding the changes (avoided till now due to Mooncake.fdata mutation for structs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for Mooncake to be used for functions using
solve!,init.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.