Backport #3733 (update to DI@0.7) to MTK@9 #4011
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix linearization t0 and bump di (cherry picked from commit d52b735)
|
If this still resolves to something old, I'll try to fix it locally, in between other stuff. |
|
Regarding the old OptimizationBase@2.11.0: It seems to be the most recent version that is compatible with MTK@9. My impression is that you'd run into the same problems without this PR when rerunning CI on the backport branch. |
|
Oh, that's unfortunate. Considering this is a minor change and v9 isn't actively maintained, I'll merge this if you confirm that it works for your use case. |
|
I started a downstream CI run with this PR and DifferentiationInterface@0.7.10. I'll report back whether it is successful. |
|
CI passed successfully, without precompilation errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should of course backport the compat update instead of just bumping compat entries (#4005).