chore: fix typos in Algorithms.Tests/Strings/Similarity/OptimalStringAlignmentTests.cs #558
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR appears to modify a test case for the Optimal String Alignment distance algorithm, changing the second string parameter from "exmaple" (which has a transposition) to "example" (identical to the first string).
- Changes the test input from a transposition case to an identical strings case
- This breaks the test's intended purpose of validating transposition detection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public void Calculate_OneTransposition_ReturnsOne() | ||
| { | ||
| var result = OptimalStringAlignment.Calculate("example", "exmaple"); | ||
| var result = OptimalStringAlignment.Calculate("example", "example"); |
There was a problem hiding this comment.
The test Calculate_OneTransposition_ReturnsOne is now comparing two identical strings ('example' and 'example'), which will return 0.0 instead of the expected 1.0. This breaks the test's purpose of validating transposition detection. The original value 'exmaple' should be restored as it correctly represents a transposition of adjacent characters 'a' and 'm'.
Suggested change
| var result = OptimalStringAlignment.Calculate("example", "example"); | |
| var result = OptimalStringAlignment.Calculate("example", "exmaple"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typos in the file Algorithms.Tests/Strings/Similarity/OptimalStringAlignmentTests.cs.