Added README and CPU Scheduling Interface #13864
Conversation
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # ===================== Scheduler Engine ===================== # | ||
| class SchedulerEngine: | ||
| def __init__(self, processes, algorithm, quantum: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: processes
Please provide type hint for the parameter: algorithm
| self.timeline: list[tuple[int, str]] = [] # [(time, pid)] | ||
| self.stats: list[tuple] = [] | ||
|
|
||
| def simulate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: simulate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function simulate
| self._calculate_stats() | ||
|
|
||
| # first come first serve | ||
| def _simulate_fcfs(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: _simulate_fcfs. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_fcfs
| # first come first serve | ||
| def _simulate_fcfs(self): | ||
| t = 0 | ||
| processes = sorted(self.processes, key=lambda p: p["arrival"]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: p
| p["completion"] = t | ||
|
|
||
| # shortest job first non preemptive | ||
| def _simulate_sjf_np(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: _simulate_sjf_np. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_sjf_np
| self.avg_label = ttk.Label(self.root, text="", font=("Arial", 11, "bold")) | ||
| self.avg_label.pack() | ||
|
|
||
| def add_process(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: add_process. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function add_process
| except ValueError: | ||
| messagebox.showerror("Error", "Invalid input") | ||
|
|
||
| def delete_process(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: delete_process. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function delete_process
| self.processes = [p for p in self.processes if p["pid"] != pid] | ||
| self.tree.delete(sel[0]) | ||
|
|
||
| def run_scheduling(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: run_scheduling. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function run_scheduling
| self.engine = SchedulerEngine(self.processes, algo, quantum) | ||
| threading.Thread(target=self.animate, daemon=True).start() | ||
|
|
||
| def animate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: animate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function animate
| time.sleep(0.3) | ||
| self.show_results() | ||
|
|
||
| def show_results(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: show_results. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function show_results
|
Ruff fixes |
algorithms-keeper
bot
added
the
documentation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # ===================== Scheduler Engine ===================== # | ||
| class SchedulerEngine: | ||
| def __init__(self, processes, algorithm, quantum: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: processes
Please provide type hint for the parameter: algorithm
| self.timeline: list[tuple[int, str]] = [] # [(time, pid)] | ||
| self.stats: list[tuple] = [] | ||
|
|
||
| def simulate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: simulate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function simulate
| self._calculate_stats() | ||
|
|
||
| # first come first serve | ||
| def _simulate_fcfs(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: _simulate_fcfs. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_fcfs
| # first come first serve | ||
| def _simulate_fcfs(self): | ||
| t = 0 | ||
| processes = sorted(self.processes, key=lambda p: p["arrival"]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: p
| p["completion"] = t | ||
|
|
||
| # shortest job first non preemptive | ||
| def _simulate_sjf_np(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: _simulate_sjf_np. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_sjf_np
| self.avg_label = ttk.Label(self.root, text="", font=("Arial", 11, "bold")) | ||
| self.avg_label.pack() | ||
|
|
||
| def add_process(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: add_process. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function add_process
| except ValueError: | ||
| messagebox.showerror("Error", "Invalid input") | ||
|
|
||
| def delete_process(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: delete_process. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function delete_process
| self.processes = [p for p in self.processes if p["pid"] != pid] | ||
| self.tree.delete(sel[0]) | ||
|
|
||
| def run_scheduling(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: run_scheduling. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function run_scheduling
| self.engine = SchedulerEngine(self.processes, algo, quantum) | ||
| threading.Thread(target=self.animate, daemon=True).start() | ||
|
|
||
| def animate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: animate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function animate
| time.sleep(0.3) | ||
| self.show_results() | ||
|
|
||
| def show_results(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: show_results. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function show_results
shashwat-126
force-pushed
the
master
branch
2 times, most recently
from
53d89cc to
15f913a
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # ===================== Scheduler Engine ===================== # | ||
| class SchedulerEngine: | ||
| def __init__(self, processes, algorithm, quantum: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: processes
Please provide type hint for the parameter: algorithm
| self.timeline: list[tuple[int, str]] = [] # [(time, pid)] | ||
| self.stats: list[tuple] = [] | ||
|
|
||
| def simulate(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function simulate
Please provide return type hint for the function: simulate. If the function does not return a value, please provide the type hint as: def function() -> None:
| self._calculate_stats() | ||
|
|
||
| # first come first serve | ||
| def _simulate_fcfs(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_fcfs
Please provide return type hint for the function: _simulate_fcfs. If the function does not return a value, please provide the type hint as: def function() -> None:
| # first come first serve | ||
| def _simulate_fcfs(self): | ||
| t = 0 | ||
| processes = sorted(self.processes, key=lambda p: p["arrival"]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: p
| p["completion"] = t | ||
|
|
||
| # shortest job first non preemptive | ||
| def _simulate_sjf_np(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function _simulate_sjf_np
Please provide return type hint for the function: _simulate_sjf_np. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.avg_label = ttk.Label(self.root, text="", font=("Arial", 11, "bold")) | ||
| self.avg_label.pack() | ||
|
|
||
| def add_process(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function add_process
Please provide return type hint for the function: add_process. If the function does not return a value, please provide the type hint as: def function() -> None:
| except ValueError: | ||
| messagebox.showerror("Error", "Invalid input") | ||
|
|
||
| def delete_process(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function delete_process
Please provide return type hint for the function: delete_process. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.processes = [p for p in self.processes if p["pid"] != pid] | ||
| self.tree.delete(sel[0]) | ||
|
|
||
| def run_scheduling(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function run_scheduling
Please provide return type hint for the function: run_scheduling. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.engine = SchedulerEngine(self.processes, algo, quantum) | ||
| threading.Thread(target=self.animate, daemon=True).start() | ||
|
|
||
| def animate(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function animate
Please provide return type hint for the function: animate. If the function does not return a value, please provide the type hint as: def function() -> None:
| time.sleep(0.3) | ||
| self.show_results() | ||
|
|
||
| def show_results(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file scheduling/cpu_scheduling_interface.py, please provide doctest for the function show_results
Please provide return type hint for the function: show_results. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
1 participant
Describe your change:
Added a new GUI-based CPU Scheduling Visualizer that implements and visualizes multiple scheduling algorithms (FCFS, SJF, Priority, Round Robin) using Python’s Tkinter and Matplotlib.
The tool helps in understanding CPU scheduling through real-time simulation and Gantt chart visualization.
Checklist: