Skip to content

Fix: incorrect output for Binary Search with duplicate elements #13840 #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Fix: incorrect output for Binary Search with duplicate elements #13840 #13869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions searches/binary_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,17 +202,18 @@ def binary_search(sorted_collection: list[int], item: int) -> int:
raise ValueError("sorted_collection must be sorted in ascending order")
left = 0
right = len(sorted_collection) - 1

answer = -1
while left <= right:
midpoint = left + (right - left) // 2
current_item = sorted_collection[midpoint]
if current_item == item:
return midpoint
answer = midpoint
right = midpoint - 1
elif item < current_item:
right = midpoint - 1
else:
left = midpoint + 1
return -1
return answer


def binary_search_std_lib(sorted_collection: list[int], item: int) -> int:
Expand Down