Skip to content

rename cause to reason to avoid esnext conflicts #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rename cause to reason to avoid esnext conflicts #87

wants to merge 1 commit into from

Conversation

@saintedlama
Copy link

@saintedlama saintedlama commented May 13, 2022

No description provided.

@ThomWright
Copy link
Owner

ThomWright commented May 13, 2022

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

@saintedlama
Copy link
Author

saintedlama commented May 17, 2022

Will do a second PR and see what's happening using an Error as cause

@saintedlama
Copy link
Author

saintedlama commented May 20, 2022

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

Works with using type Error for cause. New PR #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saintedlama @ThomWright