Skip to content

Updated network transform message #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop-2.0.0
Choose a base branch
from
Open

Updated network transform message #3743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90fbc86
Updated network transform message
Squashi11 Oct 26, 2025
64deaf5
Merge branch 'develop-2.0.0' into patch-1
Squashi11 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions com.unity.netcode.gameobjects/Runtime/Messaging/Messages/NetworkTransformMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int
return false;
}

// Get the target NetworkTransform
// Get the target NetworkTransform
var transform = networkObject.ChildNetworkBehaviours[networkBehaviourId] as NetworkTransform;
if (transform == null)
{
Debug.LogError($"[{nameof(NetworkTransformMessage)}][Invalid] Targeted {nameof(NetworkTransform)}, {nameof(NetworkBehaviour.NetworkBehaviourId)} ({networkBehaviourId}), does not exist! Make sure you are not spawning {nameof(NetworkObject)}s with disabled {nameof(GameObject)}s that have {nameof(NetworkBehaviour)} components on them.");
Debug.LogError(networkObject.gameObject.name);
Copy link
Collaborator

@EmandM EmandM Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that this fixes the issue of finding the name of the game object, however that name is being logged without any context. We prefer to ensure that our error logs have enough context to understand what the error message is trying to communicate.

A better fix would be to edit the log underneath and add the gameobject name into the existing log.

Debug.LogError($"[{nameof(NetworkTransformMessage)}][Invalid] Targeted {(NetworkTransform.gameObject)}, {nameof(NetworkBehaviour.NetworkBehaviourId)} ({networkBehaviourId}), does not exist! Make sure you are not spawning {nameof(NetworkObject)}s with disabled {nameof(GameObject)}s that have {nameof(NetworkBehaviour)} components on them.");
return false;
}

Expand Down