-
Notifications
You must be signed in to change notification settings - Fork 1.3k
elecrow_crowpanel_4_2_epaper: fix e-ink display inverted color #10707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit fixes the inverted color for the e-ink display. Previously, the text was white on a black background; now, it's a black text on a white background.
|
I am already using this display and with this patch I would have to change my application program. No big deal, but I don't think one choice is better than the other, so we could just leave it as it is. |
|
The default colors are inverted in the code, and the initial screen that displays the console is also affected. For beginners, it would be better to have correct functionality to avoid dealing with this issue. I lost many hours trying to identify what I had done wrong, but it wasn't me. |
|
Also I'm new to the world of CircuitPython maybe it's not the right fix but there is something wrong. |
|
To summarize:
|
|
On MagTag, which is kind of the prototypical use of an e-ink display, the default background is black, and the "Normal build" examples work as you describe above. On displays like a monochrome or grayscale OLED display, the default background is also black (not lit). @tannewt may have a comment about why we chose black as the default background on e-inks. |
|
Even on color displays the background defaults to black. |
Make sense. But In my mind the e-ink default background was white. Is maybe an misconception of my part, as I may be fool as I see almost all example on internet with a white background. |
|
We can close the PR if it doesn't make sense. |
There's no fool here. It is true that one often thinks of the background color of an e-ink display as white. We're trying to make the background color be consistent across many displays, so that you could port code between display types without changing the colors. (There are other changes you might need to make, such as display size and refresh strategy.) |
|
I will close for now. |
This commit fixes the inverted color for the e-ink display.
Previously, the text was white on a black background; now, it's a black text on a white background.