Optimize memory usage when sending data on Windows #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marty1885
reviewed
Oct 12, 2024
Comment on lines
746
to
+751
| #ifndef _WIN32 | ||
| ssize_t TcpConnectionImpl::writeRaw(const void *buffer, size_t length) | ||
| #else | ||
| static int sendDataWin(int fd, const char *buffer, int length, int sendBufSize) | ||
| { | ||
| int n = 0; |
There was a problem hiding this comment.
This ifndef is really confusing for no good reason. The function deceleration ssize_t TcpConnectionImpl::writeRaw(const void *buffer, size_t length) is also repeated once at the end of the else clause. We should clean this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.