Skip to content

feat(aria/tabs): Extend public api with open methods #32196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(aria/tabs): Extend public api with open methods #32196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8adcf2
feat(aria/tabs): Extend public api with open methods
adolgachev Oct 29, 2025
e1cc197
feat(aria/tabs): Add accessors for pattern properties
adolgachev Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 53 additions & 10 deletions src/aria/tabs/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,17 @@ export class Tabs {
this._unorderedPanels.set(new Set(this._unorderedPanels()));
}
}

/** Opens the tab panel with the specified value. */
open(value: string) {
const tab = this._findTabPatternByValue(value);

tab?.expansion.open();
}

_findTabPatternByValue(value: string) {
return this.tabs()?.find(t => t.value() === value);
}
}

/**
Expand All @@ -120,10 +131,10 @@ export class Tabs {
host: {
'role': 'tablist',
'class': 'ng-tablist',
'[attr.tabindex]': '_pattern.tabindex()',
'[attr.aria-disabled]': '_pattern.disabled()',
'[attr.aria-orientation]': '_pattern.orientation()',
'[attr.aria-activedescendant]': '_pattern.activedescendant()',
'[attr.tabindex]': 'tabindex()',
'[attr.aria-disabled]': 'disabled()',
'[attr.aria-orientation]': 'orientation()',
'[attr.aria-activedescendant]': 'activedescendant()',
'(keydown)': '_pattern.onKeydown($event)',
'(pointerdown)': '_pattern.onPointerdown($event)',
'(focusin)': 'onFocus()',
Expand Down Expand Up @@ -173,6 +184,15 @@ export class TabList implements OnInit, OnDestroy {
/** The current selected tab. */
readonly selectedTab = model<string | undefined>();

/** The id of the current active tab. */
readonly activedescendant = computed(() => this._pattern.activedescendant());

/** Whether selection should follow focus. */
readonly followFocus = computed(() => this._pattern.followFocus());

/** The tabindex of the tablist. */
readonly tabindex = computed(() => this._pattern.tabindex());

/** The TabList UIPattern. */
readonly _pattern: TabListPattern = new TabListPattern({
...this,
Expand Down Expand Up @@ -225,11 +245,11 @@ export class TabList implements OnInit, OnDestroy {
host: {
'role': 'tab',
'class': 'ng-tab',
'[attr.data-active]': '_pattern.active()',
'[attr.data-active]': 'active()',
'[attr.id]': '_pattern.id()',
'[attr.tabindex]': '_pattern.tabindex()',
'[attr.aria-selected]': '_pattern.selected()',
'[attr.aria-disabled]': '_pattern.disabled()',
'[attr.tabindex]': 'tabindex()',
'[attr.aria-selected]': 'selected()',
'[attr.aria-disabled]': 'disabled()',
'[attr.aria-controls]': '_pattern.controls()',
},
})
Expand Down Expand Up @@ -263,6 +283,18 @@ export class Tab implements HasElement, OnInit, OnDestroy {
/** A local unique identifier for the tab. */
readonly value = input.required<string>();

/** Whether the tab is active. */
readonly active = computed(() => this._pattern.active());

/** Whether the tab is expanded. */
readonly expanded = computed(() => this._pattern.expanded());

/** Whether the tab is selected. */
readonly selected = computed(() => this._pattern.selected());

/** The tabindex of the tab. */
readonly tabindex = computed(() => this._pattern.tabindex());

/** The Tab UIPattern. */
readonly _pattern: TabPattern = new TabPattern({
...this,
Expand All @@ -272,6 +304,11 @@ export class Tab implements HasElement, OnInit, OnDestroy {
value: this.value,
});

/** Opens this tab panel. */
open() {
this._pattern.expansion.open();
}

ngOnInit() {
this._tabList.register(this);
}
Expand All @@ -296,8 +333,8 @@ export class Tab implements HasElement, OnInit, OnDestroy {
'role': 'tabpanel',
'class': 'ng-tabpanel',
'[attr.id]': '_pattern.id()',
'[attr.tabindex]': '_pattern.tabindex()',
'[attr.inert]': '_pattern.hidden() ? true : null',
'[attr.tabindex]': 'tabindex()',
'[attr.inert]': 'hidden() ? true : null',
'[attr.aria-labelledby]': '_pattern.labelledBy()',
},
hostDirectives: [
Expand All @@ -323,6 +360,12 @@ export class TabPanel implements OnInit, OnDestroy {
/** A local unique identifier for the tabpanel. */
readonly value = input.required<string>();

/** Whether the tab panel is hidden. */
readonly hidden = computed(() => this._pattern.hidden());

/** The tabindex of the tab panel. */
readonly tabindex = computed(() => this._pattern.tabindex());

/** The TabPanel UIPattern. */
readonly _pattern: TabPanelPattern = new TabPanelPattern({
...this,
Expand Down
Loading