refactor(aria/multi): Add accessors for pattern properties #32220
Conversation
adolgachev
requested review from
ok7sai and
wagnermaciel
and removed request for
a team
adolgachev
force-pushed
the
aria-props
branch
from
0e85248 to
61d7ae0
Compare
adolgachev
changed the title
adolgachev
force-pushed
the
aria-props
branch
4 times, most recently
from
181fcb8 to
fd799bd
Compare
adolgachev
added
target: rc
adolgachev
force-pushed
the
aria-props
branch
6 times, most recently
from
1591234 to
450a94d
Compare
src/aria/grid/grid.ts
Outdated
| readonly colWrap = input<'continuous' | 'loop' | 'nowrap'>('loop'); | ||
|
|
||
| /** The currently active cell. */ | ||
| readonly activeCell = computed(() => this._pattern.activeCell()); |
There was a problem hiding this comment.
activeCell is the ui pattern type, so we might want to hide it.
src/aria/grid/grid.ts
Outdated
| readonly isFocused = computed(() => this._pattern.isFocused()); | ||
|
|
||
| /** Whether to pause grid navigation. */ | ||
| readonly pauseNavigation = computed(() => this._pattern.pauseNavigation()); |
There was a problem hiding this comment.
This is implementation detail so let's not expose this.
src/aria/toolbar/toolbar.ts
Outdated
| /** Whether the widget is currently active (focused). */ | ||
| readonly active = computed(() => this._pattern.active()); | ||
| /** Whether the widget is currently the active one (focused). */ | ||
| readonly active = computed(() => this._pattern.active); |
There was a problem hiding this comment.
This seems to return a signal function which I am not sure if it's intended.
There was a problem hiding this comment.
Oops! That got messed up in the merge. Thanks for the catch.
src/aria/menu/menu.ts
Outdated
| readonly isFocused = computed(() => this._pattern.isFocused()); | ||
|
|
||
| /** Whether the menu has received focus. */ | ||
| readonly hasBeenFocused = computed(() => this._pattern.hasBeenFocused()); |
There was a problem hiding this comment.
This is implementation detail for setting default state that I don't think developers should rely on this.
There was a problem hiding this comment.
I was thinking that too. Should we also then remove hasBeenFocused pre-existing that from before? I added them mostly because that was there to see if we wanted it.
There was a problem hiding this comment.
Actually those are referenced at this level so can't be private or removed. I'll add a note to fix or add to the spreadsheet to track clean-up.
adolgachev
force-pushed
the
aria-props
branch
from
1a4dca7 to
f407f57
Compare
angular-robot
bot
added
the
area: build & ci
adolgachev
force-pushed
the
aria-props
branch
from
96a0c8f to
a9384a6
Compare
adolgachev
force-pushed
the
aria-props
branch
from
a9384a6 to
1c43757
Compare
adolgachev
added
area: cdk/a11y
and removed
area: build & ci
3 participants
No description provided.