refactor(aria/multi): Add methods to public api #32237
Conversation
adolgachev
force-pushed
the
aria-methods
branch
from
96691eb to
e8300da
Compare
adolgachev
requested review from
ok7sai and
wagnermaciel
and removed request for
a team
| } | ||
|
|
||
| /** Opens the combobox. */ | ||
| open(nav?: {first?: boolean; last?: boolean; selected?: boolean}) { |
There was a problem hiding this comment.
We should discuss with the team how these navigation options are surfaced to developers. When it was an internal impl detail, it was fine to just call open({first: true}), etc. But now that it is part of the public api, it would be good to see if folks think there is a more intuitive way to expose this
There was a problem hiding this comment.
That's fair. I will add that the context-menu example appears to call _pattern.first() because there was no option to open and navigate to first, so at least providing it in the open (or simply making the default first: true) will remove the need to expose navigation separately. But again, just having it clearly navigate to first would possibly be enough.
| } | ||
|
|
||
| /** Selects an item in the combobox popup. */ | ||
| select(opts: {item?: V; commit?: boolean; close?: boolean} = {}) { |
There was a problem hiding this comment.
We shouldn't expose item, or close as options here. Not sure what we should do about commit, but will likely need to go a different route than surfacing it as a option this way
adolgachev
added
action: review
2 participants
No description provided.