fix(symfony): do not load docs routes if docs disabled #7448
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
Oct 8, 2025
alexndlm
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Tickets | |
| License | MIT |
| Doc PR |
soyuka
reviewed
Oct 9, 2025
src/Symfony/Routing/ApiLoader.php
Outdated
| { | ||
| $routeCollection->addCollection($this->fileLoader->load('docs.xml')); | ||
| if ($this->docsEnabled) { | ||
| $routeCollection->addCollection($this->fileLoader->load('docs.xml')); |
Contributor
There was a problem hiding this comment.
Yes, it need to be done also: symfony/symfony#60568
We should add a 2nd transformation class in https://github.com/GromNaN/symfony-config-xml-to-php
Member
|
We did not do this on purpose a when using JSON-LD you sematically need to have the |
Contributor
Author
I'm sorry, but I don't think it's a good idea. I also refactored a little, please check. |
Member
|
can you rebase, don't you have a way to disable the open api docs? can you explain a little bit more what you want to disable ? |
alexndlm
force-pushed
the
feature/do-not-load-docs-routes-if-docs-disabled
branch
from
7ff2c24 to
3777747
Compare
Contributor
Author
|
Rebased. The main goal is not to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.