-
Notifications
You must be signed in to change notification settings - Fork 148
Update OpenAPIKit to v4 #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you @iT0ny, which of the changes were required when bumping the OpenAPIKit version, and which ones were nice to have? |
All of them are required, tests mentioned in the PR message were failing. + there was an issue with nil checks after the version bump |
1c0603e to
a2407d9
Compare
|
updated user.email to correctly point to my GitHub email address |
|
Heads up that because of a change that merged into main between when this PR was opened and now, you'll need to require OpenAPIKit v4.3.1 or greater once you've rebased on latest main. |
…emaWarningsForwardedToGeneratorDiagnostics`
04d9eea to
0aa0187
Compare
|
Thanks, done! @mattpolzin |
|
@czechboy0 more of a procedural question: what is your versioning strategy around bumping OpenAPIKit major versions? Some potential considerations:
|
|
TBD, but it's possible we'll do a leap from 3 to 5 directly, as even moving to 4 would require a bit more qualification on my end that I don't have time for right now. |
Context
Duplicate of #830. This PR implements the additional changes/fixes for issues surfaced in the original PR
Summary
Details
testEmitsComplexOpenAPIParsingErrorandtestSchemaWarningsForwardedToGeneratorDiagnostics(Tests/OpenAPIGeneratorCoreTests/Parser/Test_YamsParser.swift,Tests/OpenAPIGeneratorCoreTests/Translator/TypesTranslator/Test_translateSchemas.swift)Sources/_OpenAPIGeneratorCore/Translator/CommonTranslations/translateRawEnum.swiftTests/OpenAPIGeneratorCoreTests/Translator/TypeAssignment/Test_TypeMatcher.swiftTesting
swift testFixes #821